* [PATCH] blackfin: bf60x: clock: return 0 upon error from clk_round_rate()
@ 2013-11-27 1:00 Paul Walmsley
2013-12-03 2:34 ` Steven Miao
0 siblings, 1 reply; 2+ messages in thread
From: Paul Walmsley @ 2013-11-27 1:00 UTC (permalink / raw)
To: Steven Miao, Bob Liu, Mike Frysinger; +Cc: uclinux-dist-devel, linux-kernel
clk_round_rate() should return 0 upon an error, rather than returning
a negative error code. This is because clk_round_rate() is being
changed to return an unsigned return type rather than a signed type,
since some clock sources can generate rates higher than (2^31)-1 Hz.
Signed-off-by: Paul Walmsley <pwalmsley@nvidia.com>
Cc: Steven Miao <realmz6@gmail.com>
Cc: Bob Liu <lliubbo@gmail.com>
Cc: Mike Frysinger <vapier@gentoo.org>
---
Applies on v3.13-rc1. See also:
http://marc.info/?l=linux-arm-kernel&m=138542591313620&w=2
arch/blackfin/mach-bf609/clock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/blackfin/mach-bf609/clock.c b/arch/blackfin/mach-bf609/clock.c
index dab8849af884..3f5323d3e116 100644
--- a/arch/blackfin/mach-bf609/clock.c
+++ b/arch/blackfin/mach-bf609/clock.c
@@ -131,7 +131,7 @@ EXPORT_SYMBOL(clk_get_rate);
long clk_round_rate(struct clk *clk, unsigned long rate)
{
- long ret = -EIO;
+ long ret = 0;
if (clk->ops && clk->ops->round_rate)
ret = clk->ops->round_rate(clk, rate);
return ret;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] blackfin: bf60x: clock: return 0 upon error from clk_round_rate()
2013-11-27 1:00 [PATCH] blackfin: bf60x: clock: return 0 upon error from clk_round_rate() Paul Walmsley
@ 2013-12-03 2:34 ` Steven Miao
0 siblings, 0 replies; 2+ messages in thread
From: Steven Miao @ 2013-12-03 2:34 UTC (permalink / raw)
To: Paul Walmsley
Cc: Bob Liu, Mike Frysinger, uclinux-dist-devel,
open list:CAN NETWORK DRIVERS <linux-can@vger.kernel.org>,
open list:NETWORKING DRIVERS <netdev@vger.kernel.org>,
open list
Hi Paul,
Applied to next 3.14 tree. Thanks!
On Wed, Nov 27, 2013 at 9:00 AM, Paul Walmsley <pwalmsley@nvidia.com> wrote:
>
> clk_round_rate() should return 0 upon an error, rather than returning
> a negative error code. This is because clk_round_rate() is being
> changed to return an unsigned return type rather than a signed type,
> since some clock sources can generate rates higher than (2^31)-1 Hz.
>
> Signed-off-by: Paul Walmsley <pwalmsley@nvidia.com>
> Cc: Steven Miao <realmz6@gmail.com>
> Cc: Bob Liu <lliubbo@gmail.com>
> Cc: Mike Frysinger <vapier@gentoo.org>
> ---
> Applies on v3.13-rc1. See also:
>
> http://marc.info/?l=linux-arm-kernel&m=138542591313620&w=2
>
> arch/blackfin/mach-bf609/clock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/blackfin/mach-bf609/clock.c
> b/arch/blackfin/mach-bf609/clock.c
> index dab8849af884..3f5323d3e116 100644
> --- a/arch/blackfin/mach-bf609/clock.c
> +++ b/arch/blackfin/mach-bf609/clock.c
> @@ -131,7 +131,7 @@ EXPORT_SYMBOL(clk_get_rate);
>
> long clk_round_rate(struct clk *clk, unsigned long rate)
> {
> - long ret = -EIO;
> + long ret = 0;
> if (clk->ops && clk->ops->round_rate)
> ret = clk->ops->round_rate(clk, rate);
> return ret;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-03 2:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-27 1:00 [PATCH] blackfin: bf60x: clock: return 0 upon error from clk_round_rate() Paul Walmsley
2013-12-03 2:34 ` Steven Miao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®