From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Kirill Tkhai <tkhai@yandex.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [RFC] rtmutex: Do not boost fair tasks each other
Date: Sun, 4 May 2014 14:13:13 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1405041412490.6261@ionos.tec.linutronix.de> (raw)
In-Reply-To: <20140504071758.GK17778@laptop.programming.kicks-ass.net>
On Sun, 4 May 2014, Peter Zijlstra wrote:
> On Sat, May 03, 2014 at 08:54:08PM +0200, Thomas Gleixner wrote:
> > On Thu, 1 May 2014, Kirill Tkhai wrote:
> > > Higher priority does not provide exclusive privilege
> > > of one fair task over the other. In this case priority
> > > boosting looks excess.
> > >
> > > On RT patch with enabled PREEMPT_RT_FULL I see a lot of
> > > rt_mutex_setprio() actions like
> > >
> > > 120 -> 118
> > > 118 -> 120
> > >
> > > They harm RT tasks.
> >
> > That's not the main problem. The point is that it is useless and
> > therefor harming performace and throughput as well.
> >
> > > RT patch has lazy preemtion feature, so if idea is we care
> > > about excess preemption inside fair class, we should care
> > > about excess priority inheritance too.
> > >
> > > In case of vanila kernel the problem is the same, but there
> > > are no so many rt mutexes. Do I skip anything?
> >
> > Almost a decade ago we decided to do the boosting for everything
> > including SCHED_OTHER due to the very simple reason that exercising
> > that code path more is likely to trigger more bugs.
> >
> > But yes in a production environment, it's pointless for SCHED_OTHER
> > tasks.
> >
> > Though exercising that code path as much as we can is not a bad thing
> > either. So I'd like to see that made compile time conditional on one
> > of the lock testing CONFIG items.
> >
> > And the patch should be made against mainline, where we have the same
> > issue (reduced to PI-futexes).
>
> And of course, if we ever get to PEP, we very much want all the classes
> to participate :)
That's true. We deal with it when it arrives :)
next prev parent reply other threads:[~2014-05-04 12:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 9:21 Kirill Tkhai
2014-05-03 18:54 ` Thomas Gleixner
2014-05-04 7:17 ` Peter Zijlstra
2014-05-04 12:13 ` Thomas Gleixner [this message]
2014-05-05 18:31 ` Kirill Tkhai
2014-05-28 20:26 ` Thomas Gleixner
2014-05-29 20:52 ` Kirill Tkhai
2014-06-17 14:19 ` Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1405041412490.6261@ionos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tkhai@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®