From: Jamie Lentin <jm@lentin.co.uk>
To: Antonio Ospite <ao2@ao2.it>
Cc: Jiri Kosina <jkosina@suse.cz>,
Hans de Goede <hdegoede@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/4] HID: lenovo: Add support for Lenovo Compact Keyboard
Date: Sat, 26 Jul 2014 11:09:35 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.02.1407261047480.24969@marmot.wormnet.eu> (raw)
In-Reply-To: <20140725160527.13cbeae1108fce5e09b6daae@ao2.it>
On Fri, 25 Jul 2014, Antonio Ospite wrote:
> On Wed, 23 Jul 2014 23:30:44 +0100
> Jamie Lentin <jm@lentin.co.uk> wrote:
>
>> This patchset follows on from my previous attempts to add support for
>> these keyboards from Lenovo.
>>
>> Antonio, I've used cptkbd_data and left data_pointer for now. It'd be
>> an easy patch to change data_pointer to tpkbd_data, but is drifting
>> away from what this patchset is supposed to do. Could send that
>> afterwards though.
>>
>
> Sure, no problem. I think we are good to go.
>
> BTW I was considering picking up one of such compact keyboards myself,
> but I read that the BT one uses the USB cable only for charging
> and it does not show as a USB HID device when plugged in, can you
> confirm that?
Yes, nothing happens over USB other than charging. It's slightly
irritating since I have to keep something else to hand for booting, or try
and get a dongle that goes into a HID proxy mode.
That said, I quite like it as a keyboard and happily use it for working
all day. Interestingly the bluetooth version is nicer to type on than the
USB version, even though they look physically identical. This could be
they came from different batches rather than using better keys for the
Bluetooth version.
> Thanks,
> Antonio
next prev parent reply other threads:[~2014-07-26 10:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 22:30 Jamie Lentin
2014-07-23 22:30 ` [PATCH v5 1/4] HID: lenovo: Rename hid-lenovo-tpkbd to hid-lenovo Jamie Lentin
2014-07-25 12:56 ` Antonio Ospite
2014-07-23 22:30 ` [PATCH v5 2/4] HID: lenovo: Prepare support for adding other devices Jamie Lentin
2014-07-25 12:58 ` Antonio Ospite
2014-07-23 22:30 ` [PATCH v5 3/4] HID: lenovo: Style fixes Jamie Lentin
2014-07-23 23:37 ` Dmitry Torokhov
2014-07-25 13:33 ` Antonio Ospite
2014-07-26 14:42 ` [PATCH v6 3/4] HID: lenovo: Don't call function in condition, show error codes Jamie Lentin
2014-07-28 17:46 ` Dmitry Torokhov
2014-07-23 22:30 ` [PATCH v5 4/4] HID: lenovo: Add support for Compact (BT|USB) keyboard Jamie Lentin
2014-07-25 13:39 ` Antonio Ospite
2014-07-25 14:05 ` [PATCH v5 0/4] HID: lenovo: Add support for Lenovo Compact Keyboard Antonio Ospite
2014-07-26 10:09 ` Jamie Lentin [this message]
2014-07-29 9:25 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1407261047480.24969@marmot.wormnet.eu \
--to=jm@lentin.co.uk \
--cc=ao2@ao2.it \
--cc=hdegoede@redhat.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®