From: atull <atull@opensource.altera.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: kbuild test robot <fengguang.wu@intel.com>, <kbuild-all@01.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can be static
Date: Fri, 12 Dec 2014 09:31:57 -0600 [thread overview]
Message-ID: <alpine.DEB.2.02.1412120931340.29302@linuxheads99> (raw)
In-Reply-To: <20141211204030.42c33e71@lxorguk.ukuu.org.uk>
On Thu, 11 Dec 2014, One Thousand Gnomes wrote:
> On Thu, 11 Dec 2014 09:43:24 +0800
> kbuild test robot <fengguang.wu@intel.com> wrote:
>
> > drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?
> >
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>
> Ought to be const as well by the look of it - we don't want function
> pointers in patchable memory spaces.
>
I agree. Will be in v5.
Alan
prev parent reply other threads:[~2014-12-12 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 1:43 [socfpga-nex:for_next-fpgamgr-without-overlays-v4.3 8/9] drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static? kbuild test robot
2014-12-11 1:43 ` [PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can be static kbuild test robot
2014-12-11 20:40 ` One Thousand Gnomes
2014-12-12 15:31 ` atull [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1412120931340.29302@linuxheads99 \
--to=atull@opensource.altera.com \
--cc=devel@driverdev.osuosl.org \
--cc=fengguang.wu@intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome