[socfpga-nex:for_next-fpgamgr-without-overlays-v4.3 8/9] drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?

[socfpga-nex:for_next-fpgamgr-without-overlays-v4.3 8/9] drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?

[kbuild test robot]

tree:   git://git.rocketboards.org/linux-socfpga-next for_next-fpgamgr-without-overlays-v4.3
head:   7920447fc75922e9a72db640cddf890d75a30e0d
commit: 99aa2d008ce7a2a925368bfddd53ae83d307fb38 [8/9] staging: fpga manager: add driver for socfpga fpga manager
reproduce:
  # apt-get install sparse
  git checkout 99aa2d008ce7a2a925368bfddd53ae83d307fb38
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can be static

[kbuild test robot]

drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 socfpga.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fpga/socfpga.c b/drivers/staging/fpga/socfpga.c
index 4440b84..ae9a2f1 100644
--- a/drivers/staging/fpga/socfpga.c
+++ b/drivers/staging/fpga/socfpga.c
@@ -652,7 +652,7 @@ static int socfpga_fpga_resume(struct fpga_manager *mgr)
 	return ret;
 }
 
-struct fpga_manager_ops socfpga_fpga_ops = {
+static struct fpga_manager_ops socfpga_fpga_ops = {
 	.reset = socfpga_fpga_reset,
 	.state = socfpga_fpga_ops_state,
 	.write_init = socfpga_fpga_ops_configure_init,

Re: [PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can be static

[One Thousand Gnomes]

On Thu, 11 Dec 2014 09:43:24 +0800
kbuild test robot <fengguang.wu@intel.com> wrote:

> drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Ought to be const as well by the look of it - we don't want function
pointers in patchable memory spaces.

Re: [PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can be static

[atull]

On Thu, 11 Dec 2014, One Thousand Gnomes wrote:

> On Thu, 11 Dec 2014 09:43:24 +0800
> kbuild test robot <fengguang.wu@intel.com> wrote:
> 
> > drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?
> > 
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> Ought to be const as well by the look of it - we don't want function
> pointers in patchable memory spaces.
> 

I agree.  Will be in v5.

Alan