From: Peter Meerwald <pmeerw@pmeerw.net>
To: Martin Kepplinger <martink@posteo.de>
Cc: jic23@kernel.org, christoph.muellner@theobroma-systems.com,
martin.kepplinger@theobroma-systems.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 0/2] iio: mma8452: add support for 3 more devices
Date: Tue, 30 Jun 2015 13:39:10 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1506301336410.12832@pmeerw.net> (raw)
In-Reply-To: <1435663602-29868-1-git-send-email-martink@posteo.de>
Hello Martin,
> The first patch doesn't change anything for existing users of mma8452. Please
> test this if you can!
nice to see the driver improved!
the first patch does quite I bit more than it claims; it's not only
adding more device, I'd prefer the patch split up for review
> The second patch corrects how interrupts are described as IIO events. It exists
> seperately because it changes the driver's behaviour for existing users of
> mma8452.
what is the difference?
thanks, p.
--
Peter Meerwald
+43-664-2444418 (mobile)
next prev parent reply other threads:[~2015-06-30 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 11:26 Martin Kepplinger
2015-06-30 11:26 ` [PATCH 1/2] iio: mma8452: add support for 3 more accelerometer chips Martin Kepplinger
2015-06-30 11:49 ` Daniel Baluta
2015-06-30 11:26 ` [PATCH 2/2] iio: mma8452: change iio event type to IIO_EV_TYPE_MAG Martin Kepplinger
2015-06-30 11:39 ` Peter Meerwald [this message]
2015-06-30 12:21 ` [PATCH 0/2] iio: mma8452: add support for 3 more devices Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1506301336410.12832@pmeerw.net \
--to=pmeerw@pmeerw.net \
--cc=christoph.muellner@theobroma-systems.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.kepplinger@theobroma-systems.com \
--cc=martink@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®