From: atull <atull@opensource.altera.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Pavel Machek <pavel@denx.de>, Josh Cartwright <joshc@ni.com>,
<mark.rutland@arm.com>, <linux-doc@vger.kernel.org>,
<rubini@gnudd.com>, <pantelis.antoniou@konsulko.com>,
<hpa@zytor.com>, <s.trumtrar@pengutronix.de>,
<devel@driverdev.osuosl.org>, <sameo@linux.intel.com>,
<nico@linaro.org>, <ijc+devicetree@hellion.org.uk>,
<michal.simek@xilinx.com>, <kyle.teske@ni.com>,
<jgunthorpe@obsidianresearch.com>, <grant.likely@linaro.org>,
<davidb@codeaurora.org>, <linus.walleij@linaro.org>,
<cesarb@cesarb.net>, <devicetree@vger.kernel.org>,
<jason@lakedaemon.net>, <pawel.moll@arm.com>,
<iws@ovro.caltech.edu>, <broonie@kernel.org>,
<philip@balister.org>, "Petr Cvek" <petr.cvek@tul.cz>,
<dinguyen@opensource.altera.com>, <monstr@monstr.eu>,
<gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
<balbi@ti.com>, <delicious.quinoa@gmail.com>,
<robh+dt@kernel.org>, <rob@landley.net>, <galak@codeaurora.org>,
<akpm@linux-foundation.org>, <davem@davemloft.net>,
<m.chehab@samsung.com>
Subject: Re: [PATCH v11 3/4] add FPGA manager core
Date: Wed, 23 Sep 2015 11:15:16 -0500 [thread overview]
Message-ID: <alpine.DEB.2.02.1509231101050.23595@linuxheads99> (raw)
In-Reply-To: <20150923141106.GH4953@mwanda>
On Wed, 23 Sep 2015, Dan Carpenter wrote:
> On Wed, Sep 23, 2015 at 03:23:54PM +0200, Pavel Machek wrote:
> > > > +int fpga_mgr_firmware_load(struct fpga_manager *mgr, u32 flags,
> > > > + const char *image_name)
> > > > +{
> > > > + struct device *dev = &mgr->dev;
> > > > + const struct firmware *fw;
> > > > + int ret;
> > > > +
> > > > + if (!mgr)
> > > > + return -ENODEV;
> > >
> > > Again; I'm of the opinion this is needlessly defensive.
> >
> > Not only that, it can never happen. mgr is already dereferenced above.
> >
>
> It's not dereferenced. We're taking the address of mgr->dev but we
> don't dereference mgr.
>
> regards,
> dan carpenter
>
>
That's correct, it's not dereferenced.
Is there some community agreement on whether we want to check a pointer
that has been passed for NULL or not? This is C code after all. Checking
a passed pointer for NULL is a very common reason to return -ENODEV.
Alan
next prev parent reply other threads:[~2015-09-23 16:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 15:21 [PATCH v11 0/4] FPGA Manager Framework atull
2015-09-22 15:21 ` [PATCH v11 1/4] usage documentation for FPGA manager core atull
2015-09-23 0:50 ` Moritz Fischer
2015-09-22 15:21 ` [PATCH v11 2/4] fpga manager: add sysfs interface document atull
2015-09-23 0:52 ` Moritz Fischer
2015-09-22 15:21 ` [PATCH v11 3/4] add FPGA manager core atull
2015-09-22 22:29 ` Josh Cartwright
2015-09-23 13:23 ` Pavel Machek
2015-09-23 14:11 ` Dan Carpenter
2015-09-23 16:15 ` atull [this message]
2015-09-24 7:49 ` Dan Carpenter
2015-09-24 20:47 ` atull
2015-09-24 21:13 ` Pavel Machek
2015-09-25 10:00 ` Dan Carpenter
2015-09-23 17:10 ` atull
2015-09-23 23:03 ` Josh Cartwright
2015-09-24 20:24 ` atull
2015-09-22 15:21 ` [PATCH v11 4/4] fpga manager: add driver for socfpga fpga manager atull
2015-09-22 22:47 ` Josh Cartwright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1509231101050.23595@linuxheads99 \
--to=atull@opensource.altera.com \
--cc=akpm@linux-foundation.org \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=cesarb@cesarb.net \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=davidb@codeaurora.org \
--cc=delicious.quinoa@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=iws@ovro.caltech.edu \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=joshc@ni.com \
--cc=kyle.teske@ni.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=nico@linaro.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=pavel@denx.de \
--cc=pawel.moll@arm.com \
--cc=petr.cvek@tul.cz \
--cc=philip@balister.org \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=rubini@gnudd.com \
--cc=s.trumtrar@pengutronix.de \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome