From: Julia Lawall <julia.lawall@lip6.fr>
To: Weng Xuetian <wengxt@gmail.com>
Cc: Chen Yu <yu.c.chen@intel.com>, Darren Hart <dvhart@infradead.org>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Weng Xuetian <wengxt@gmail.com>,
kbuild-all@01.org
Subject: [PATCH] surface pro 4: fix compare_const_fl.cocci warnings
Date: Sun, 27 Dec 2015 22:10:58 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1512272208490.2085@localhost6.localdomain6> (raw)
Move constants to the right of binary operators.
Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
CC: Weng Xuetian <wengxt@gmail.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
It's not a big deal, but the constant on the right looks nicer to me.
key_code seems like the more important information, so it is nice to see
it first.
surfacepro_button.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/platform/x86/surfacepro_button.c
+++ b/drivers/platform/x86/surfacepro_button.c
@@ -111,7 +111,7 @@ static void surface_button_notify(struct
break;
}
input = button->input;
- if (KEY_RESERVED == key_code)
+ if (key_code == KEY_RESERVED)
return;
if (pressed)
pm_wakeup_event(&device->dev, 0);
next reply other threads:[~2015-12-27 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-27 21:10 Julia Lawall [this message]
2016-01-14 23:15 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1512272208490.2085@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=dvhart@infradead.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=wengxt@gmail.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®