From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<ard.biesheuvel@linaro.org>, <mark.rutland@arm.com>,
<stefano.stabellini@citrix.com>, <david.vrabel@citrix.com>,
<catalin.marinas@arm.com>, <will.deacon@arm.com>,
<julien.grall@citrix.com>, <xen-devel@lists.xen.org>,
<devicetree@vger.kernel.org>, <linux-efi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <ian.campbell@citrix.com>,
<shannon.zhao@linaro.org>, <peter.huangpeng@huawei.com>
Subject: Re: [PATCH v3 10/17] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI
Date: Mon, 25 Jan 2016 15:19:37 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1601251512580.9687@kaball.uk.xensource.com> (raw)
In-Reply-To: <1453519184-11908-11-git-send-email-zhaoshenglong@huawei.com>
On Sat, 23 Jan 2016, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> When booting with ACPI, it could get the event-channel irq through
> HVM_PARAM_CALLBACK_IRQ.
>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> arch/arm/xen/enlighten.c | 36 +++++++++++++++++++++++++++++++++++-
> 1 file changed, 35 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index 6d90a62..0e010bb 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -29,6 +29,7 @@
> #include <linux/time64.h>
> #include <linux/timekeeping.h>
> #include <linux/timekeeper_internal.h>
> +#include <linux/acpi.h>
>
> #include <linux/mm.h>
>
> @@ -262,6 +263,35 @@ void __init xen_early_init(void)
> add_preferred_console("hvc", 0, NULL);
> }
>
> +static void __init xen_acpi_guest_init_events_irq(void)
please rename it to "xen_acpi_guest_init"
> +{
> +#ifdef CONFIG_ACPI
> + struct xen_hvm_param a;
> + int interrupt, trigger, polarity;
> +
> + a.domid = DOMID_SELF;
> + a.index = HVM_PARAM_CALLBACK_IRQ;
> + xen_events_irq = 0;
> +
> + if (!HYPERVISOR_hvm_op(HVMOP_get_param, &a)) {
> + if ((a.value >> 56) == HVM_PARAM_CALLBACK_TYPE_EVENT) {
> + interrupt = a.value & 0xff;
> + trigger = ((a.value >> 8) & 0x1) ? ACPI_EDGE_SENSITIVE
> + : ACPI_LEVEL_SENSITIVE;
> + polarity = ((a.value >> 8) & 0x2) ? ACPI_ACTIVE_LOW
> + : ACPI_ACTIVE_HIGH;
> + xen_events_irq = acpi_register_gsi(NULL, interrupt,
> + trigger, polarity);
> + }
> + }
> +#endif
> +}
> +
> +static void __init xen_dt_guest_init_events_irq(void)
"xen_dt_guest_init"
Provided that you make these two changes:
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> +{
> + xen_events_irq = irq_of_parse_and_map(xen_node, 0);
> +}
> +
> static int __init xen_guest_init(void)
> {
> struct xen_add_to_physmap xatp;
> @@ -270,7 +300,11 @@ static int __init xen_guest_init(void)
> if (!xen_domain())
> return 0;
>
> - xen_events_irq = irq_of_parse_and_map(xen_node, 0);
> + if (!acpi_disabled)
> + xen_acpi_guest_init_events_irq();
> + else
> + xen_dt_guest_init_events_irq();
> +
> if (!xen_events_irq) {
> pr_err("Xen event channel interrupt not found\n");
> return -ENODEV;
> --
> 2.0.4
>
>
next prev parent reply other threads:[~2016-01-25 15:20 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 3:19 [PATCH v3 00/17] Add ACPI support for Xen Dom0 on ARM64 Shannon Zhao
2016-01-23 3:19 ` [PATCH v3 01/17] Xen: ACPI: Hide UART used by Xen Shannon Zhao
2016-01-25 12:20 ` Stefano Stabellini
2016-01-23 3:19 ` [PATCH v3 02/17] xen/grant-table: Move xlated_setup_gnttab_pages to common place Shannon Zhao
2016-01-23 3:19 ` [PATCH v3 03/17] Xen: xlate: Use page_to_xen_pfn instead of page_to_pfn Shannon Zhao
2016-01-25 13:55 ` Stefano Stabellini
2016-01-23 3:19 ` [PATCH v3 04/17] arm/xen: Use xen_xlate_map_ballooned_pages to setup grant table Shannon Zhao
2016-01-23 3:19 ` [PATCH v3 05/17] xen: memory : Add new XENMAPSPACE type XENMAPSPACE_dev_mmio Shannon Zhao
2016-01-23 3:19 ` [PATCH v3 06/17] Xen: ARM: Add support for mapping platform device mmio Shannon Zhao
2016-01-23 3:19 ` [PATCH v3 07/17] Xen: ARM: Add support for mapping AMBA " Shannon Zhao
2016-01-23 3:19 ` [PATCH v3 08/17] Xen: public/hvm: sync changes of HVM_PARAM_CALLBACK_VIA ABI from Xen Shannon Zhao
2016-01-25 15:06 ` Stefano Stabellini
2016-01-23 3:19 ` [PATCH v3 09/17] xen/hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ Shannon Zhao
2016-01-25 15:08 ` Stefano Stabellini
2016-01-23 3:19 ` [PATCH v3 10/17] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI Shannon Zhao
2016-01-25 15:19 ` Stefano Stabellini [this message]
2016-01-23 3:19 ` [PATCH v3 11/17] ARM: XEN: Move xen_early_init() before efi_init() Shannon Zhao
2016-01-25 15:25 ` Stefano Stabellini
2016-01-23 3:19 ` [PATCH v3 12/17] ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI Shannon Zhao
2016-01-25 15:32 ` Stefano Stabellini
2016-01-27 8:27 ` Hanjun Guo
2016-01-27 8:57 ` Shannon Zhao
2016-01-23 3:19 ` [PATCH v3 13/17] ARM: Xen: Document UEFI support on Xen ARM virtual platforms Shannon Zhao
2016-01-25 15:50 ` Stefano Stabellini
2016-01-25 15:59 ` Mark Rutland
2016-01-25 16:06 ` Stefano Stabellini
2016-01-23 3:19 ` [PATCH v3 14/17] XEN: EFI: Move x86 specific codes to architecture directory Shannon Zhao
2016-01-25 16:44 ` Stefano Stabellini
2016-01-26 8:16 ` Shannon Zhao
2016-01-26 11:31 ` Stefano Stabellini
2016-01-26 12:26 ` Shannon Zhao
2016-01-23 3:19 ` [PATCH v3 15/17] ARM64: XEN: Add a function to initialize Xen specific UEFI runtime services Shannon Zhao
2016-01-25 16:47 ` Stefano Stabellini
2016-01-23 3:19 ` [PATCH v3 16/17] FDT: Add a helper to get specified name subnode Shannon Zhao
2016-01-26 12:11 ` Stefano Stabellini
2016-01-26 12:27 ` Shannon Zhao
2016-01-23 3:19 ` [PATCH v3 17/17] Xen: EFI: Parse DT parameters for Xen specific UEFI Shannon Zhao
2016-01-26 11:41 ` Stefano Stabellini
2016-01-26 12:05 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1601251512580.9687@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=david.vrabel@citrix.com \
--cc=devicetree@vger.kernel.org \
--cc=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peter.huangpeng@huawei.com \
--cc=shannon.zhao@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=will.deacon@arm.com \
--cc=xen-devel@lists.xen.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®