From: Julia Lawall <julia.lawall@lip6.fr>
To: ByeoungWook Kim <quddnr145@gmail.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
gregkh@linuxfoundation.org, ksenija.stanojevic@gmail.com,
luisbg@osg.samsung.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: Fix block comments use * on subsequent lines in r8192U_wx.c
Date: Mon, 1 Feb 2016 08:35:03 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1602010834100.2052@localhost6.localdomain6> (raw)
In-Reply-To: <CAOxTRzqmtXbs9w1UFkBgON4mWcmOXg8sQug1Xzo6PhxObq+_+g@mail.gmail.com>
On Mon, 1 Feb 2016, ByeoungWook Kim wrote:
> The current realtek driver was written like my patch comments. but
> Documentation/CodingStyle isn't before.
> So I wrote patch like current realtek driver.
That is probably fine, then. Sorry for the noise. I looked at some other
code in the kernel, and it didn't have it.
julia
>
> How should i do it?
>
> Regards,
> Byeoungwook.
>
> 2016-02-01 16:01 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>:
> >
> >
> > On Mon, 1 Feb 2016, Byeoungwook Kim wrote:
> >
> >> clean up checkpatch warning:
> >> WARNING: Block comments use * on subsequent lines
> >>
> >> Signed-off-by: Byeoungwook Kim <quddnr145@gmail.com>
> >> ---
> >> drivers/staging/rtl8192u/r8192U_wx.c | 38 +++++++++++++++++++-----------------
> >> 1 file changed, 20 insertions(+), 18 deletions(-)
> >>
> >> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> >> index 4911fef..f828e64 100644
> >> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> >> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> >> @@ -1,21 +1,23 @@
> >> -/*
> >> - This file contains wireless extension handlers.
> >> -
> >> - This is part of rtl8180 OpenSource driver.
> >> - Copyright (C) Andrea Merello 2004-2005 <andrea.merello@gmail.com>
> >> - Released under the terms of GPL (General Public Licence)
> >> -
> >> - Parts of this driver are based on the GPL part
> >> - of the official realtek driver.
> >> -
> >> - Parts of this driver are based on the rtl8180 driver skeleton
> >> - from Patric Schenke & Andres Salomon.
> >> -
> >> - Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
> >> -
> >> - We want to thank the Authors of those projects and the Ndiswrapper
> >> - project Authors.
> >> -*/
> >> +/******************************************************************************
> >
> > Is the row of *s needed?
> >
> > julia
> >
> >> + *
> >> + * This file contains wireless extension handlers.
> >> + *
> >> + * This is part of rtl8180 OpenSource driver.
> >> + * Copyright (C) Andrea Merello 2004-2005 <andrea.merello@gmail.com>
> >> + * Released under the terms of GPL (General Public Licence)
> >> + *
> >> + * Parts of this driver are based on the GPL part
> >> + * of the official realtek driver.
> >> + *
> >> + * Parts of this driver are based on the rtl8180 driver skeleton
> >> + * from Patric Schenke & Andres Salomon.
> >> + *
> >> + * Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
> >> + *
> >> + * We want to thank the Authors of those projects and the Ndiswrapper
> >> + * project Authors.
> >> + *
> >> + *****************************************************************************/
> >>
> >> #include <linux/string.h>
> >> #include "r8192U.h"
> >> --
> >> 2.5.0
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >>
>
next prev parent reply other threads:[~2016-02-01 7:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 5:16 Byeoungwook Kim
2016-02-01 7:01 ` Julia Lawall
2016-02-01 7:31 ` ByeoungWook Kim
2016-02-01 7:35 ` Julia Lawall [this message]
2016-02-01 5:22 Byeoungwook Kim
2016-02-01 5:35 Byeoungwook Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1602010834100.2052@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=ksenija.stanojevic@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luisbg@osg.samsung.com \
--cc=quddnr145@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®