mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Liam Mark <lmark@codeaurora.org>
To: Laura Abbott <labbott@redhat.com>
Cc: devel@driverdev.osuosl.org, Greg KH <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2] staging: android: ion: Zero CMA allocated memory
Date: Wed, 24 Jan 2018 16:40:27 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.02.1801241638130.13091@lmark-linux.qualcomm.com> (raw)
In-Reply-To: <d347fc8a-02c6-d24e-dad5-3781c6330e0d@redhat.com>

On Wed, 24 Jan 2018, Laura Abbott wrote:

> On 01/22/2018 09:46 AM, Liam Mark wrote:
> > Since commit 204f672255c2 ("staging: android: ion: Use CMA APIs directly")
> > the CMA API is now used directly and therefore the allocated memory is no
> > longer automatically zeroed.
> > 
> > Explicitly zero CMA allocated memory to ensure that no data is exposed to
> > userspace.
> > 
> > Fixes: 204f672255c2 ("staging: android: ion: Use CMA APIs directly")
> > Signed-off-by: Liam Mark <lmark@codeaurora.org>
> > ---
> > Changes in v2:
> >    - Clean up the commit message.
> >    - Add 'Fixes:'
> > 
> >   drivers/staging/android/ion/ion_cma_heap.c | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/staging/android/ion/ion_cma_heap.c
> > b/drivers/staging/android/ion/ion_cma_heap.c
> > index 86196ffd2faf..91a98785607a 100644
> > --- a/drivers/staging/android/ion/ion_cma_heap.c
> > +++ b/drivers/staging/android/ion/ion_cma_heap.c
> > @@ -51,6 +51,8 @@ static int ion_cma_allocate(struct ion_heap *heap, struct
> > ion_buffer *buffer,
> >   	if (!pages)
> >   		return -ENOMEM;
> > 
> > +	memset(page_address(pages), 0, size);
> > +
> 
> This won't work for highmem pages. You need to zero by page via
> kmap_atomic in that case. You can use PageHighMem to separate the
> paths.

Thanks for catching that, I will update the patch.

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

      reply	other threads:[~2018-01-25  0:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 17:46 Liam Mark
2018-01-24 10:19 ` Laura Abbott
2018-01-25  0:40   ` Liam Mark [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1801241638130.13091@lmark-linux.qualcomm.com \
    --to=lmark@codeaurora.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=labbott@redhat.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®