From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org,
mingo@kernel.org, eranian@google.com,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/5] perf, x86: Remove incorrect model number from Haswell perf
Date: Tue, 26 Aug 2014 23:27:37 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1408262325200.3323@nanos> (raw)
In-Reply-To: <1409006611-30741-2-git-send-email-andi@firstfloor.org>
On Mon, 25 Aug 2014, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> arch/x86/kernel/cpu/perf_event_intel.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
> index 89bc750..e280a86 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel.c
> @@ -2541,10 +2541,9 @@ __init int intel_pmu_init(void)
>
>
> case 60: /* 22nm Haswell */
> + case 70:
> case 63:
> case 69:
> - case 70:
> - case 71:
So what's the point of making the obvious onliner patch
- case 71:
into something which reorders the sorted case numbers?
And of course, this patch is missing any explanation WHY 71 is
incorrect and how it got there in the first place.
Thanks,
tglx
next prev parent reply other threads:[~2014-08-26 21:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 22:43 Broadwell perf support Andi Kleen
2014-08-25 22:43 ` [PATCH 1/5] perf, x86: Remove incorrect model number from Haswell perf Andi Kleen
2014-08-26 21:27 ` Thomas Gleixner [this message]
2014-08-26 21:29 ` Andi Kleen
2014-08-26 22:29 ` Thomas Gleixner
2014-08-27 9:53 ` Thomas Gleixner
2014-08-27 16:37 ` Andi Kleen
2014-08-27 18:50 ` Thomas Gleixner
2014-08-25 22:43 ` [PATCH 2/5] perf, x86: Document all Haswell models Andi Kleen
2014-09-01 13:50 ` Peter Zijlstra
2014-08-25 22:43 ` [PATCH 3/5] perf, x86: Add Broadwell core support Andi Kleen
2014-09-01 13:51 ` Peter Zijlstra
2014-11-04 13:14 ` Stephane Eranian
2014-11-04 13:20 ` Peter Zijlstra
2014-08-25 22:43 ` [PATCH 4/5] perf, x86: Add INST_RETIRED.ALL workarounds Andi Kleen
2014-09-01 13:41 ` Peter Zijlstra
2014-08-25 22:43 ` [PATCH 5/5] perf, x86: Use Broadwell cache event list for Haswell Andi Kleen
2014-09-01 13:52 ` Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2014-09-02 18:44 [PATCH 1/5] perf, x86: Remove incorrect model number from Haswell perf Andi Kleen
2014-09-18 22:42 ` Peter Zijlstra
2014-08-27 21:03 perf, x86: Updated Broadwell patchkit Andi Kleen
2014-08-27 21:03 ` [PATCH 1/5] perf, x86: Remove incorrect model number from Haswell perf Andi Kleen
2014-08-14 1:17 Updated Broadwell perf patchkit Andi Kleen
2014-08-14 1:17 ` [PATCH 1/5] perf, x86: Remove incorrect model number from Haswell perf Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1408262325200.3323@nanos \
--to=tglx@linutronix.de \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®