From: Julia Lawall <julia.lawall@lip6.fr>
To: Ben Skeggs <bskeggs@redhat.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org
Subject: Re: drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c:70:2-8: preceding lock on line 67
Date: Wed, 14 Oct 2015 14:30:35 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1510141429490.2421@hadrien> (raw)
In-Reply-To: <201510141846.22W2v2Rw%fengguang.wu@intel.com>
Please check whether not releasing the lock is intentional.
julia
On Wed, 14 Oct 2015, kbuild test robot wrote:
> CC: kbuild-all@01.org
> CC: linux-kernel@vger.kernel.org
> TO: Ben Skeggs <bskeggs@redhat.com>
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 5b5f1455272e23f4e7889cec37228802d8d01adf
> commit: 344c2d429dd86b1b0113177e18f15adb74e9d936 drm/nouveau/fb: remove dependence on namedb/engctx lookup
> date: 7 weeks ago
> :::::: branch date: 16 hours ago
> :::::: commit date: 7 weeks ago
>
> >> drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c:70:2-8: preceding lock on line 67
>
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git remote update linus
> git checkout 344c2d429dd86b1b0113177e18f15adb74e9d936
> vim +70 drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c
>
> 344c2d42 Ben Skeggs 2015-08-20 61 }
> 344c2d42 Ben Skeggs 2015-08-20 62
> 344c2d42 Ben Skeggs 2015-08-20 63 struct nvkm_fifo_chan *
> 344c2d42 Ben Skeggs 2015-08-20 64 nvkm_fifo_chan_chid(struct nvkm_fifo *fifo, int chid, unsigned long *rflags)
> 344c2d42 Ben Skeggs 2015-08-20 65 {
> 344c2d42 Ben Skeggs 2015-08-20 66 unsigned long flags;
> 344c2d42 Ben Skeggs 2015-08-20 @67 spin_lock_irqsave(&fifo->lock, flags);
> 344c2d42 Ben Skeggs 2015-08-20 68 if (fifo->channel[chid]) {
> 344c2d42 Ben Skeggs 2015-08-20 69 *rflags = flags;
> 344c2d42 Ben Skeggs 2015-08-20 @70 return (void *)fifo->channel[chid];
> 344c2d42 Ben Skeggs 2015-08-20 71 }
> 344c2d42 Ben Skeggs 2015-08-20 72 spin_unlock_irqrestore(&fifo->lock, flags);
> 344c2d42 Ben Skeggs 2015-08-20 73 return NULL;
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
next parent reply other threads:[~2015-10-14 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201510141846.22W2v2Rw%fengguang.wu@intel.com>
2015-10-14 12:30 ` Julia Lawall [this message]
2015-10-14 23:31 ` Ben Skeggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1510141429490.2421@hadrien \
--to=julia.lawall@lip6.fr \
--cc=bskeggs@redhat.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®