From: Julia Lawall <julia.lawall@lip6.fr>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Kris Borer <kborer@gmail.com>, Michal Marek <mmarek@suse.com>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr
Subject: Re: [PATCH v2] coccinelle: add style check for assignment in if
Date: Tue, 9 Feb 2016 10:18:22 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.10.1602091016200.2578@hadrien> (raw)
In-Reply-To: <56B9A2F6.4040109@users.sourceforge.net>
On Tue, 9 Feb 2016, SF Markus Elfring wrote:
> > +virtual patch
>
> How do you think about to use this variable in a subsequent
> SmPL rule?
>
> Would you like to consider also the reuse of SmPL variables
> like "org" and "report"?
I think that there is no point for these things, because checkpatch
already gives warnings about this issue.
It could be nice for the provided rules to actually depend on patch. But
in the context of make coccicheck, it doesn't matter, because attempts to
run the rule in another mode will just fail, due to the mode not being
declared.
julia
next prev parent reply other threads:[~2016-02-09 9:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 12:46 Kris Borer
2016-02-09 8:27 ` SF Markus Elfring
2016-02-09 9:18 ` Julia Lawall [this message]
2016-02-09 12:55 ` SF Markus Elfring
2016-02-09 23:56 ` Joe Perches
2016-02-10 9:00 ` SF Markus Elfring
2016-02-10 15:06 ` Kris Borer
-- strict thread matches above, loose matches on Subject: below --
2015-11-17 16:34 [PATCH v2] " Kris Borer
2015-08-22 17:04 Kris Borer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1602091016200.2578@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=elfring@users.sourceforge.net \
--cc=kborer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome