* [PATCH 0982/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 12:05 Baole Ni
2016-08-02 12:47 ` Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Baole Ni @ 2016-08-02 12:05 UTC (permalink / raw)
To: gregkh, m.chehab, m.szyprowski, kyungmin.park, k.kozlowski
Cc: linux-usb, linux-kernel, peter.senna, akpm, luisbg, Julia.Lawall,
geliangtang, colin.king, chuansheng.liu, baolex.ni, oneukum
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/usb/host/fotg210-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
index 66efa9a..7ad395e 100644
--- a/drivers/usb/host/fotg210-hcd.c
+++ b/drivers/usb/host/fotg210-hcd.c
@@ -4789,7 +4789,7 @@ out_unlock:
return ret;
}
-static DEVICE_ATTR(uframe_periodic_max, 0644, show_uframe_periodic_max,
+static DEVICE_ATTR(uframe_periodic_max, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, show_uframe_periodic_max,
store_uframe_periodic_max);
static inline int create_sysfs_files(struct fotg210_hcd *fotg210)
--
2.9.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0982/1285] Replace numeric parameter like 0444 with macro
2016-08-02 12:05 [PATCH 0982/1285] Replace numeric parameter like 0444 with macro Baole Ni
@ 2016-08-02 12:47 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-08-02 12:47 UTC (permalink / raw)
To: Baole Ni
Cc: gregkh, m.chehab, m.szyprowski, kyungmin.park, k.kozlowski,
linux-usb, linux-kernel, peter.senna, akpm, luisbg, Julia.Lawall,
geliangtang, colin.king, chuansheng.liu, oneukum
On Tue, 2 Aug 2016, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
> drivers/usb/host/fotg210-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
> index 66efa9a..7ad395e 100644
> --- a/drivers/usb/host/fotg210-hcd.c
> +++ b/drivers/usb/host/fotg210-hcd.c
> @@ -4789,7 +4789,7 @@ out_unlock:
> return ret;
> }
>
> -static DEVICE_ATTR(uframe_periodic_max, 0644, show_uframe_periodic_max,
> +static DEVICE_ATTR(uframe_periodic_max, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, show_uframe_periodic_max,
Over 80 chars.
julia
> store_uframe_periodic_max);
>
> static inline int create_sysfs_files(struct fotg210_hcd *fotg210)
> --
> 2.9.2
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-02 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 12:05 [PATCH 0982/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 12:47 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®