From: Christoph Lameter <cl@linux.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>
Subject: Re: linux-next: Tree for Aug 29
Date: Mon, 1 Sep 2014 16:15:52 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.11.1409011615210.22966@gentwo.org> (raw)
In-Reply-To: <20140901173521.GA8259@roeck-us.net>
On Mon, 1 Sep 2014, Guenter Roeck wrote:
> arch/ia64/sn/kernel/setup.c: In function 'sn_cpu_init':
> arch/ia64/sn/kernel/setup.c:632:13: error: lvalue required as left operand of assignment
> make[1]: *** [arch/ia64/sn/kernel/setup.o] Error 1
> make: *** [arch/ia64/sn/kernel/setup.o] Error 2
Subject: ia64: sn_nodepda cannot be assigned to after this_cpu conversion. Use __this_cpu_write.
There must be an explit statement to modify the percpu variable after the conversion of the
sn_nodpda macro to use this_cpu_read.
Signed-off-by: Christoph Lameter <cl@linux.com>
Index: linux/arch/ia64/sn/kernel/setup.c
===================================================================
--- linux.orig/arch/ia64/sn/kernel/setup.c
+++ linux/arch/ia64/sn/kernel/setup.c
@@ -629,7 +629,7 @@ void sn_cpu_init(void)
cnode = nasid_to_cnodeid(nasid);
- sn_nodepda = nodepdaindr[cnode];
+ __this_cpu_write(__sn_nodepda, nodepdaindr[cnode]);
pda->led_address =
(typeof(pda->led_address)) (LED0 + (slice << LED_CPU_SHIFT));
next prev parent reply other threads:[~2014-09-01 21:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 5:07 Stephen Rothwell
2014-08-29 11:28 ` Mark Brown
2014-09-01 17:35 ` Guenter Roeck
2014-09-01 21:15 ` Christoph Lameter [this message]
2014-09-01 22:00 ` Guenter Roeck
2014-09-02 15:54 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2025-08-29 4:47 Stephen Rothwell
2024-08-29 7:25 Stephen Rothwell
2023-08-29 6:53 Stephen Rothwell
2022-08-29 5:53 Stephen Rothwell
2019-08-29 11:08 Stephen Rothwell
2018-08-29 3:40 Stephen Rothwell
2017-08-29 9:16 Stephen Rothwell
2013-08-29 10:00 Stephen Rothwell
2011-08-29 6:19 Stephen Rothwell
2011-08-29 6:52 ` Sedat Dilek
2011-08-29 7:19 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1409011615210.22966@gentwo.org \
--to=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sfr@canb.auug.org.au \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®