mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <ak@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Don Zickus <dzickus@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Anton Blanchard <anton@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v1] watchdog: Use a reference cycle counter to avoid scaling issues
Date: Fri, 24 Apr 2015 13:50:05 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1504241344310.13914@nanos> (raw)
In-Reply-To: <20150424095906.GL13605@tassilo.jf.intel.com>

On Fri, 24 Apr 2015, Andi Kleen wrote:
> > There are better ways to do that than using heuristics. We have to
> > deal with 3 variants of the reference counter:
> > 
> > 1) Core and Atom: counts bus cycles and we know that frequency already
> >    	    	  from the local apic calibration
> > 
> > 2) Nehalem, Westmere: Same as TSC
> > 
> > 3) Sandybridge and later:  XCLK which is 100MHz
> > 
> > No magic calibration, just use the information which we have on our
> > hands already.
> 
> This is a really bad idea. We basically would need to maintain a big
> switch with model numbers, with new cases added for every new CPU.
> Would be a maintenance nightmare.

Nonsense. We have already enough family specific switch cases which
need to be maintained for every new cpu anyway. So they can simply
provide that extra bit of information. It's neither rocket science nor
a nightmare.

We don't need to calibrate stuff which we can access by simpler means.

Thanks,

	tglx



  reply	other threads:[~2015-04-24 11:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 15:03 Alexander Shishkin
2015-04-23 20:01 ` Thomas Gleixner
2015-04-23 20:32   ` Andi Kleen
2015-04-23 21:37     ` Thomas Gleixner
2015-04-24  0:51       ` Andi Kleen
2015-04-24  8:44         ` Thomas Gleixner
2015-04-24  9:35           ` Thomas Gleixner
2015-04-24  9:46             ` Alexander Shishkin
2015-04-24  9:48               ` Thomas Gleixner
2015-04-24  9:59           ` Andi Kleen
2015-04-24 11:50             ` Thomas Gleixner [this message]
2015-04-24  9:01         ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1504241344310.13914@nanos \
    --to=tglx@linutronix.de \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=anton@samba.org \
    --cc=dzickus@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=stable@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®