From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: peterz@infradead.org, eranian@google.com,
linux-kernel@vger.kernel.org, kan.liang@intel.com,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/3] x86, perf, uncore: Don't make MSR uncore depend on PCI uncore
Date: Tue, 16 Jun 2015 14:06:00 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1506161352451.4120@nanos> (raw)
In-Reply-To: <1434347862-28490-3-git-send-email-andi@firstfloor.org>
On Sun, 14 Jun 2015, Andi Kleen wrote:
> @@ -1287,27 +1289,17 @@ static void __init uncore_cpumask_init(void)
>
> static int __init intel_uncore_init(void)
> {
> - int ret;
> -
> if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
> return -ENODEV;
>
> if (cpu_has_hypervisor)
> return -ENODEV;
>
> - ret = uncore_pci_init();
> - if (ret)
> - goto fail;
> - ret = uncore_cpu_init();
> - if (ret) {
> - uncore_pci_exit();
> - goto fail;
> - }
> + uncore_pci_init();
> + uncore_cpu_init();
> uncore_cpumask_init();
So, even if the cpu does not support that, we install a completely
useless cpu notifier and invoke equally pointless init code on all
cores.
Sigh,
tglx
next prev parent reply other threads:[~2015-06-16 12:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 5:57 [PATCH 1/3] x86, perf, uncore: Add support for ARB uncore PMU on Sandy/IvyBridge Andi Kleen
2015-06-15 5:57 ` [PATCH 2/3] x86, perf, uncore: Use Sandy Bridge client PMU on Haswell/Broadwell Andi Kleen
2015-08-04 8:52 ` [tip:perf/core] perf/x86/intel/uncore: " tip-bot for Andi Kleen
2015-06-15 5:57 ` [PATCH 3/3] x86, perf, uncore: Don't make MSR uncore depend on PCI uncore Andi Kleen
2015-06-16 12:06 ` Thomas Gleixner [this message]
2015-08-04 8:52 ` [tip:perf/core] perf/x86/intel/uncore: Add support for ARB uncore PMU on Sandy/IvyBridge tip-bot for Andi Kleen
2015-06-18 20:45 Updated Haswell uncore PMU patchkit Andi Kleen
2015-06-18 20:46 ` [PATCH 3/3] x86, perf, uncore: Don't make MSR uncore depend on PCI uncore Andi Kleen
2015-06-18 21:12 ` Thomas Gleixner
2015-06-18 22:48 ` Andi Kleen
2015-06-18 22:57 ` Thomas Gleixner
2015-06-18 23:02 Another Haswell uncore patchkit Andi Kleen
2015-06-18 23:02 ` [PATCH 3/3] x86, perf, uncore: Don't make MSR uncore depend on PCI uncore Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1506161352451.4120@nanos \
--to=tglx@linutronix.de \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®