From: Thomas Gleixner <tglx@linutronix.de>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: devel@linuxdriverproject.org,
"K. Y. Srinivasan" <kys@microsoft.com>,
linux-kernel@vger.kernel.org, "Dexuan Cui" <decui@microsoft.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Radim Krčmář" <rkrcmar@redhat.com>,
gregkh@linuxfoundation.org
Subject: Re: [PATCH v5 1/2] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable
Date: Thu, 25 Jun 2015 16:57:59 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1506251652300.4037@nanos> (raw)
In-Reply-To: <1435240249-8893-2-git-send-email-vkuznets@redhat.com>
On Thu, 25 Jun 2015, Vitaly Kuznetsov wrote:
> Loaded Hyper-V module will use these functions to disable CPU hotplug
> under certain circumstances. Convert cpu_hotplug_disabled to a counter
> (protected by cpu_add_remove_lock) to support e.g. disable -> disable ->
> enable call sequences.
This changelog including the subject line still sucks.
Q: How is the counter change related subject line?
A: Not at all.
Q: Why do we need to change this to a counter?
A: Because
Q: What problem is being solved?
A: Dunno
Q: Why do we need the export?
A: HyperV having certain circumstances
Summary: The changelog is useless
The patch wants to be split in two parts:
1) Make the counter change and explain why the current mode is not
sufficient and what kind of problem can be solved
2) Export the functions with a proper explanation why.
Thanks,
tglx
next prev parent reply other threads:[~2015-06-25 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 13:50 [PATCH v5 0/2] Drivers: hv: vmbus: use cpu_hotplug_enable/disable for CPU offlining prevention Vitaly Kuznetsov
2015-06-25 13:50 ` [PATCH v5 1/2] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable Vitaly Kuznetsov
2015-06-25 14:57 ` Thomas Gleixner [this message]
2015-06-25 13:50 ` [PATCH v5 2/2] Drivers: hv: vmbus: use cpu_hotplug_enable/disable Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1506251652300.4037@nanos \
--to=tglx@linutronix.de \
--cc=decui@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rkrcmar@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®