* [PATCH 3/5] arc:irqchip: prepare for drivers/irqchip/irqchip.h removal
@ 2015-07-07 21:14 Joël Porquet
2015-07-08 1:58 ` Vineet Gupta
0 siblings, 1 reply; 3+ messages in thread
From: Joël Porquet @ 2015-07-07 21:14 UTC (permalink / raw)
To: linux-kernel; +Cc: vgupta, monstr, ralf, tglx, jason
The IRQCHIP_DECLARE macro migrated to 'include/linux/irqchip.h'.
See commit 91e20b5040c67c51aad88cf87db4305c5bd7f79d
("irqchip: Move IRQCHIP_DECLARE macro to include/linux/irqchip.h").
This patch removes the inclusions of private header 'drivers/irqchip/irqchip.h'
and if necessary replaces them with inclusions of 'include/linux/irqchip.h'.
Signed-off-by: Joel Porquet <joel@porquet.org>
---
arch/arc/kernel/intc-arcv2.c | 1 -
arch/arc/kernel/intc-compact.c | 1 -
arch/arc/kernel/mcip.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/arch/arc/kernel/intc-arcv2.c b/arch/arc/kernel/intc-arcv2.c
index 6208c63..26c1568 100644
--- a/arch/arc/kernel/intc-arcv2.c
+++ b/arch/arc/kernel/intc-arcv2.c
@@ -12,7 +12,6 @@
#include <linux/of.h>
#include <linux/irqdomain.h>
#include <linux/irqchip.h>
-#include "../../drivers/irqchip/irqchip.h"
#include <asm/irq.h>
/*
diff --git a/arch/arc/kernel/intc-compact.c b/arch/arc/kernel/intc-compact.c
index fcdddb6..039fac3 100644
--- a/arch/arc/kernel/intc-compact.c
+++ b/arch/arc/kernel/intc-compact.c
@@ -12,7 +12,6 @@
#include <linux/of.h>
#include <linux/irqdomain.h>
#include <linux/irqchip.h>
-#include "../../drivers/irqchip/irqchip.h"
#include <asm/irq.h>
/*
diff --git a/arch/arc/kernel/mcip.c b/arch/arc/kernel/mcip.c
index 30284e8..2673975 100644
--- a/arch/arc/kernel/mcip.c
+++ b/arch/arc/kernel/mcip.c
@@ -175,7 +175,6 @@ void mcip_init_early_smp(void)
#include <linux/irqchip.h>
#include <linux/of.h>
#include <linux/of_irq.h>
-#include "../../drivers/irqchip/irqchip.h"
/*
* Set the DEST for @cmn_irq to @cpu_mask (1 bit per core)
--
2.4.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/5] arc:irqchip: prepare for drivers/irqchip/irqchip.h removal
2015-07-07 21:14 [PATCH 3/5] arc:irqchip: prepare for drivers/irqchip/irqchip.h removal Joël Porquet
@ 2015-07-08 1:58 ` Vineet Gupta
2015-07-08 7:46 ` Thomas Gleixner
0 siblings, 1 reply; 3+ messages in thread
From: Vineet Gupta @ 2015-07-08 1:58 UTC (permalink / raw)
To: Joël Porquet, linux-kernel; +Cc: monstr, ralf, tglx, jason
On Wednesday 08 July 2015 02:45 AM, Joël Porquet wrote:
The IRQCHIP_DECLARE macro migrated to 'include/linux/irqchip.h'.
See commit 91e20b5040c67c51aad88cf87db4305c5bd7f79d
("irqchip: Move IRQCHIP_DECLARE macro to include/linux/irqchip.h").
This patch removes the inclusions of private header 'drivers/irqchip/irqchip.h'
and if necessary replaces them with inclusions of 'include/linux/irqchip.h'.
Signed-off-by: Joel Porquet <joel@porquet.org><mailto:joel@porquet.org>
Acked-by: Vineet Gupta <vgupta@synopsys.com<mailto:vgupta@synopsys.com>>
Joel, Thomas : Do you want me to pick this one up ?
Thx,
-Vineet
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/5] arc:irqchip: prepare for drivers/irqchip/irqchip.h removal
2015-07-08 1:58 ` Vineet Gupta
@ 2015-07-08 7:46 ` Thomas Gleixner
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Gleixner @ 2015-07-08 7:46 UTC (permalink / raw)
To: Vineet Gupta; +Cc: Joël Porquet, linux-kernel, monstr, ralf, jason
[-- Attachment #1: Type: TEXT/PLAIN, Size: 891 bytes --]
On Wed, 8 Jul 2015, Vineet Gupta wrote:
> On Wednesday 08 July 2015 02:45 AM, Joël Porquet wrote:
>
> The IRQCHIP_DECLARE macro migrated to 'include/linux/irqchip.h'.
>
> See commit 91e20b5040c67c51aad88cf87db4305c5bd7f79d
> ("irqchip: Move IRQCHIP_DECLARE macro to include/linux/irqchip.h").
>
> This patch removes the inclusions of private header 'drivers/irqchip/irqchip.h'
> and if necessary replaces them with inclusions of 'include/linux/irqchip.h'.
>
> Signed-off-by: Joel Porquet <joel@porquet.org><mailto:joel@porquet.org>
>
> Acked-by: Vineet Gupta <vgupta@synopsys.com<mailto:vgupta@synopsys.com>>
>
> Joel, Thomas : Do you want me to pick this one up ?
Yes.
Btw, feel glad, that Joel figured this include '../../....' crap out
and not me. I certainly wouldn't have written a purely technical
changelog. include '../../....' is wrong in 99% of the cases.
Thanks,
tglx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-08 7:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-07 21:14 [PATCH 3/5] arc:irqchip: prepare for drivers/irqchip/irqchip.h removal Joël Porquet
2015-07-08 1:58 ` Vineet Gupta
2015-07-08 7:46 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®