From: Thomas Gleixner <tglx@linutronix.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Jiang Liu <jiang.liu@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] genirq: Introduce a new flag IRQ_IS_CHAINED for chained interrupts
Date: Fri, 2 Oct 2015 22:16:49 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1510022212000.4500@nanos> (raw)
In-Reply-To: <1443769052-21151-1-git-send-email-mika.westerberg@linux.intel.com>
On Fri, 2 Oct 2015, Mika Westerberg wrote:
> In some cases it is useful to know if the interrupt in question has chained
> handler installed. For example when a cpu is offlined the architecture code
> needs to know if it has any users so that it can fixup affinity
> accordingly.
>
> To make this possible we introduce a new flag IRQ_IS_CHAINED that is set by
> the core code when chained interrupt handler is installed. We also make it
> possible for core and architecture code to check the flag by introducing
> function irq_has_chained_handler() for this.
While looking at that patch it occured to me, that we can solve this
in a different way, which does not require any changes to the
migration code.
When we install the chained handler, we set the action of that irq
descriptor to a statically allocated chained_action which provides a
handler which emits a fat warning. chained handlers should never end
up calling an action and if they do, it's clearly a bug.
The availability of an action makes the migration code just pick it
and move it along. And that fixes all architectures in one go without
touching them.
Sorry, that I didn't think about this right away.
Thanks,
tglx
next prev parent reply other threads:[~2015-10-02 20:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 6:57 Mika Westerberg
2015-10-02 6:57 ` [PATCH 2/2] x86/irq: Take chained interrupts into account in fixup_irqs() Mika Westerberg
2015-10-02 20:16 ` Thomas Gleixner [this message]
2015-10-05 10:12 ` [PATCH v2] genirq: Allow migration of chained interrupts by installing default action Mika Westerberg
2015-10-09 20:54 ` [tip:irq/core] " tip-bot for Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1510022212000.4500@nanos \
--to=tglx@linutronix.de \
--cc=hpa@zytor.com \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®