mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org
Subject: Re: [PATCH 1/1] x86/intel-mid: modify a code to suppress a warning
Date: Fri, 9 Oct 2015 16:01:43 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1510091557160.6097@nanos> (raw)
In-Reply-To: <1444397355-82695-1-git-send-email-andriy.shevchenko@linux.intel.com>

On Fri, 9 Oct 2015, Andy Shevchenko wrote:

Please stop to write subject lines like this.

     x86/intel-mid: modify a code to suppress a warning

This is completely useless as it does not tell what kind of warning
(compile time, runtime). Further it says that the patch modifies
code, which is completely pointless, right?

What's wrong with:

     x86/intel-mid: Make intel_mid_ops static

I end up rewriting your subject lines and changelogs on a regular
base. You really should have noticed that by now and started to spend
a little bit more effort yourself.

Thanks,

	tglx



  reply	other threads:[~2015-10-09 14:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09 13:29 Andy Shevchenko
2015-10-09 14:01 ` Thomas Gleixner [this message]
2015-10-09 15:10   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1510091557160.6097@nanos \
    --to=tglx@linutronix.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®