From: Thomas Gleixner <tglx@linutronix.de>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: linux-kernel@vger.kernel.org, marc.zyngier@arm.com, jason@lakedaemon.net
Subject: Re: [PATCH v6 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets
Date: Mon, 12 Oct 2015 11:32:56 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1510121132030.6097@nanos> (raw)
In-Reply-To: <561B7D60.4040808@rempel-privat.de>
On Mon, 12 Oct 2015, Oleksij Rempel wrote:
> Am 11.10.2015 um 19:58 schrieb Thomas Gleixner:
> >> + icoll_add_domain(np, ICOLL_NUM_IRQS);
> >>
> >> - icoll_domain = irq_domain_add_linear(np, ICOLL_NUM_IRQS,
> >> - &icoll_irq_domain_ops, NULL);
> >> return icoll_domain ? 0 : -ENODEV;
> >
> > In case of !icoll_domain this return is not reached as you paniced
> > already. So why would we still check icoll_domain?
>
> I'm paniced on !icoll_base, icoll_domain will give only warning.
> http://lxr.free-electrons.com/source/kernel/irq/irqdomain.c#L52
>
> Or do i miss some thing?
Yes. Your patch makes that:
>> + if (!icoll_domain)
>> + panic("%s: unable add irq domain", np->full_name);
Thanks,
tglx
next prev parent reply other threads:[~2015-10-12 9:33 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 9:18 [PATCH v2 0/2] changelog Oleksij Rempel
2015-09-18 9:18 ` [PATCH v2 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2015-09-18 10:21 ` Thomas Gleixner
2015-09-18 9:18 ` [PATCH v2 2/2] ARM: irqchip: mxs: add Alpascale ASM9260 support Oleksij Rempel
2015-09-18 10:42 ` Possible Spam " Marc Zyngier
2015-09-19 5:53 ` Oleksij Rempel
2015-09-20 11:28 ` Marc Zyngier
2015-09-20 13:47 ` Oleksij Rempel
2015-09-21 9:06 ` Thomas Gleixner
2015-09-21 11:53 ` [PATCH v3 0/2] Add support for ASM9260 interrupt controller Oleksij Rempel
2015-09-21 11:53 ` [PATCH v3 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2015-09-21 11:53 ` [PATCH v3 2/2] ARM: irqchip: mxs: add Alphascale ASM9260 support Oleksij Rempel
2015-09-22 10:34 ` Thomas Gleixner
2015-09-23 16:20 ` [PATCH v4 0/2] Add support for ASM9260 interrupt controller Oleksij Rempel
2015-09-23 16:20 ` [PATCH v4 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2015-09-29 16:06 ` Thomas Gleixner
2015-10-05 19:00 ` [PATCH v5 0/2] Add support for ASM9260 interrupt controller Oleksij Rempel
2015-10-05 19:00 ` [PATCH v5 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2015-10-05 19:00 ` [PATCH v5 2/2] ARM: irqchip: mxs: add Alphascale ASM9260 support Oleksij Rempel
2015-10-09 14:11 ` Thomas Gleixner
2015-10-10 13:08 ` [PATCH v6 0/2] Add support for ASM9260 interrupt controller Oleksij Rempel
2015-10-10 13:08 ` [PATCH v6 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2015-10-11 17:58 ` Thomas Gleixner
2015-10-12 9:29 ` Oleksij Rempel
2015-10-12 9:32 ` Thomas Gleixner [this message]
2015-10-12 19:15 ` [PATCH v7 0/3] Add support for ASM9260 interrupt controller Oleksij Rempel
2015-10-12 19:15 ` [PATCH v7 1/3] ARM: irqchip: mxs: do panic if icoll_base == NULL Oleksij Rempel
2015-10-14 7:42 ` [tip:irq/core] irqchip/mxs: Panic if ioremap or domain creation fails tip-bot for Oleksij Rempel
2015-10-12 19:15 ` [PATCH v6 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2015-10-12 19:15 ` [PATCH v6 2/2] ARM: irqchip: mxs: add Alphascale ASM9260 support Oleksij Rempel
2015-10-12 19:15 ` [PATCH v7 2/3] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2015-10-14 7:42 ` [tip:irq/core] irqchip/mxs: Prepare driver for hardware " tip-bot for Oleksij Rempel
2015-10-12 19:15 ` [PATCH v7 3/3] ARM: irqchip: mxs: add Alphascale ASM9260 support Oleksij Rempel
2015-10-14 7:43 ` [tip:irq/core] irqchip/mxs: Add " tip-bot for Oleksij Rempel
2015-10-10 13:08 ` [PATCH v6 2/2] ARM: irqchip: mxs: add " Oleksij Rempel
2015-09-23 16:20 ` [PATCH v4 " Oleksij Rempel
2015-09-18 9:48 ` [PATCH v2 2/2] ARM: irqchip: mxs: add Alpascale " Oleksij Rempel
2015-09-18 10:16 ` [PATCH v2 0/2] changelog Marc Zyngier
2015-09-18 10:19 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1510121132030.6097@nanos \
--to=tglx@linutronix.de \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®