From: Thomas Gleixner <tglx@linutronix.de>
To: LABBE Corentin <clabbe.montjoie@gmail.com>
Cc: ameenali023@gmail.com, bp@alien8.de, dan.carpenter@oracle.com,
davem@davemloft.net, firogm@gmail.com,
herbert@gondor.apana.org.au, hpa@zytor.com, mingo@redhat.com,
minipli@googlemail.com, smueller@chronox.de,
tim.c.chen@linux.intel.com, x86@kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: x86: Remove duplicate define of SHA1_DIGEST_SIZE
Date: Wed, 14 Oct 2015 22:44:39 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1510142242030.3960@nanos> (raw)
In-Reply-To: <1444850171-17931-1-git-send-email-clabbe.montjoie@gmail.com>
On Wed, 14 Oct 2015, LABBE Corentin wrote:
> The sha x86 crypto code use two define for the same thing:
> NUM_SHA1_DIGEST_WORDS and SHA1_DIGEST_LENGTH
> Replace them by SHA1_DIGEST_SIZE/4
That's wrong. Use only one for the number of words and make the define
so it's derived from the LENGTH.
Thanks,
tglx
next prev parent reply other threads:[~2015-10-14 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 19:15 LABBE Corentin
2015-10-14 20:44 ` Thomas Gleixner [this message]
2015-10-16 16:04 ` Tim Chen
2015-10-29 7:51 ` LABBE Corentin
2015-10-29 16:16 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1510142242030.3960@nanos \
--to=tglx@linutronix.de \
--cc=ameenali023@gmail.com \
--cc=bp@alien8.de \
--cc=clabbe.montjoie@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=firogm@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=minipli@googlemail.com \
--cc=smueller@chronox.de \
--cc=tim.c.chen@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®