mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Sasha Levin <sasha.levin@oracle.com>,
	Richard Cochran <richardcochran@gmail.com>
Subject: Re: [RFC][PATCH -reworked] time: Verify time values in adjtimex ADJ_SETOFFSET to avoid overflow
Date: Mon, 7 Dec 2015 21:16:37 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1512072116160.3595@nanos> (raw)
In-Reply-To: <CALAqxLU6xAftp7S=PgHKY40hjq93pXCRAG6gfqyzvrgQqkv7yQ@mail.gmail.com>

On Mon, 7 Dec 2015, John Stultz wrote:
> On Mon, Dec 7, 2015 at 12:11 PM, John Stultz <john.stultz@linaro.org> wrote:
> > diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> > index 99188ee..a37222b 100644
> > --- a/kernel/time/timekeeping.c
> > +++ b/kernel/time/timekeeping.c
> > @@ -1986,6 +1986,7 @@ int do_adjtimex(struct timex *txc)
> >
> >         if (txc->modes & ADJ_SETOFFSET) {
> >                 struct timespec delta;
> > +
> >                 delta.tv_sec  = txc->time.tv_sec;
> >                 delta.tv_nsec = txc->time.tv_usec;
> >                 if (!(txc->modes & ADJ_NANO))
> 
> Gah. Except for this needless whitespace. Ignore that please.

It's needless for this patch, but correct by itself :)

  reply	other threads:[~2015-12-07 20:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04  3:09 [PATCH] time: verify " Sasha Levin
2015-12-04 20:27 ` John Stultz
2015-12-05 17:10 ` Thomas Gleixner
2015-12-06  0:15   ` Sasha Levin
2015-12-06  9:07     ` Thomas Gleixner
2015-12-06 22:11       ` Richard Cochran
2015-12-07 19:54         ` John Stultz
2015-12-07 20:11           ` [RFC][PATCH -reworked] time: Verify " John Stultz
2015-12-07 20:13             ` John Stultz
2015-12-07 20:16               ` Thomas Gleixner [this message]
2015-12-07 20:15           ` [PATCH] time: verify " Thomas Gleixner
2015-12-07 20:19             ` John Stultz
2015-12-07 20:23             ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1512072116160.3595@nanos \
    --to=tglx@linutronix.de \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®