From: Thomas Gleixner <tglx@linutronix.de>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
mingo@redhat.com, gregkh@linuxfoundation.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] base: isa: Remove X86_32 dependency
Date: Fri, 22 Jan 2016 09:07:22 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1601220905381.3886@nanos> (raw)
In-Reply-To: <56A17172.4080302@gmail.com>
On Thu, 21 Jan 2016, William Breathitt Gray wrote:
> On 01/21/2016 06:47 PM, H. Peter Anvin wrote:
> > Well, and as you can see from the build robot because a lot of those
> > drivers simply don't compile on 64-bit systems. If nothing else you
> > would have to push the 32-bit tests downward in the config dependency tree.
>
> Yes, you're right. There doesn't appear to be anything 32-bit specific in
> the ISA bus driver itself, so these build failures must be due to configs
> relying on the 32-bit dependency from CONFIG_ISA. It should be possible to
> decouple the 32-bit dependency, so I'll work through the config dependency
> tree and fix the build errors with explicit CONFIG_X86_32 dependencies. I'll
> submit a new patch with those changes when complete.
Make drivers/bus/isa.c depend on CONFIG_ISA_BUS and select that from
CONFIG_ISA.
That gives you the bus driver alone w/o touching any of the things which
depend on x32.
Thanks,
tglx
next prev parent reply other threads:[~2016-01-22 8:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 15:56 William Breathitt Gray
2016-01-21 19:40 ` H. Peter Anvin
2016-01-21 23:43 ` William Breathitt Gray
2016-01-21 23:47 ` H. Peter Anvin
2016-01-22 0:01 ` William Breathitt Gray
2016-01-22 8:07 ` Thomas Gleixner [this message]
2016-01-21 21:18 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1601220905381.3886@nanos \
--to=tglx@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=vilhelm.gray@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®