mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jan Beulich <JBeulich@suse.com>
Cc: mingo@elte.hu, hpa@zytor.com, Juergen Gross <JGross@suse.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ix86: fix types used in pgprot cachability flags translations
Date: Mon, 25 Jan 2016 17:59:06 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1601251757440.3886@nanos> (raw)
In-Reply-To: <56A65EB502000078000CAC72@prv-mh.provo.novell.com>

On Mon, 25 Jan 2016, Jan Beulich wrote:

> For PAE kernels "unsigned long" is not suitable to hold page protection
> flags, since _PAGE_NX doesn't fit there. This is the reason for quite a
> few W+X pages getting reported as insecure during boot (observed namely
> for the entire initrd range).
> 
> Quite the other way around, "unsigned long" is inefficient for 64-bit
> kernels when dealing with cachability flags alone - "unsigned int" is
> sufficient here and allows for slightly smaller code to be generated.

This part has nothing to do with the fix. Can you please avoid to mix fixes,
which require backporting and code enhancements?

Thanks,

	tglx

  reply	other threads:[~2016-01-25 17:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 16:43 Jan Beulich
2016-01-25 16:59 ` Thomas Gleixner [this message]
2016-01-26 11:15   ` [PATCH v2] " Jan Beulich
2016-01-26 11:20     ` Juergen Gross
2016-01-26 20:12     ` [tip:x86/urgent] x86/mm: Fix types used in pgprot cacheability " tip-bot for Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1601251757440.3886@nanos \
    --to=tglx@linutronix.de \
    --cc=JBeulich@suse.com \
    --cc=JGross@suse.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®