mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Brian Starkey <brian.starkey@arm.com>
Cc: linux-kernel@vger.kernel.org, marc.zyngier@arm.com
Subject: Re: [PATCH] genirq: fix trigger flags check for shared irqs
Date: Tue, 26 Jan 2016 21:45:32 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1601262142450.3886@nanos> (raw)
In-Reply-To: <96c068ece0f5d01fc85bdbd9e0798f68180eebb8.1453204950.git.brian.starkey@arm.com>

On Tue, 26 Jan 2016, Brian Starkey wrote:

> For shared interrupts, if one requester passes in any IRQF_TRIGGER_*
> flags whilst another doesn't, __setup_irq() can erroneously fail.
> 
> The no-flags case should be treated as "already configured", so change
> __setup_irq() to only check that the flags match if any have been
> provided.

What happens if that "already configured", i.e. the default setting, is
conflicting with the newly requested interrupt?

I rather prefer the failure than the resulting silent wreckage.
 
Thanks,

	tglx

  reply	other threads:[~2016-01-26 20:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26 10:31 Brian Starkey
2016-01-26 20:45 ` Thomas Gleixner [this message]
2016-01-28  9:59   ` Brian Starkey
2016-01-28 10:29     ` Thomas Gleixner
2016-01-28 11:10       ` Brian Starkey
2016-01-28 11:49         ` Thomas Gleixner
2016-01-28 12:22           ` Brian Starkey
2016-01-28 13:37             ` Thomas Gleixner
2016-02-08 11:02               ` Brian Starkey
2016-01-28 15:58           ` Rob Herring
2016-01-28 20:06             ` Thomas Gleixner
2016-01-29  4:17               ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1601262142450.3886@nanos \
    --to=tglx@linutronix.de \
    --cc=brian.starkey@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®