From: Thomas Gleixner <tglx@linutronix.de>
To: Vikas Shivappa <vikas.shivappa@intel.com>
Cc: Vikas Shivappa <vikas.shivappa@linux.intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com,
mingo@kernel.org, peterz@infradead.org, ravi.v.shankar@intel.com,
tony.luck@intel.com, fenghua.yu@intel.com,
h.peter.anvin@intel.com
Subject: Re: [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init
Date: Thu, 3 Mar 2016 19:37:33 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1603031937210.3597@nanos> (raw)
In-Reply-To: <alpine.DEB.2.10.1603031025390.32152@vshiva-Udesk>
On Thu, 3 Mar 2016, Vikas Shivappa wrote:
>
>
> On Wed, 2 Mar 2016, Thomas Gleixner wrote:
>
> > On Wed, 2 Mar 2016, Vikas Shivappa wrote:
> > > + if (cqm_enabled && mbm_enabled)
> > > + intel_cqm_events_group.attrs = intel_cmt_mbm_events_attr;
> > > + else if (!cqm_enabled && mbm_enabled)
> > > + intel_cqm_events_group.attrs = intel_mbm_events_attr;
> > > + else if (cqm_enabled && !mbm_enabled)
> > > + intel_cqm_events_group.attrs = intel_cqm_events_attr;
> > > +
> > > ret = perf_pmu_register(&intel_cqm_pmu, "intel_cqm", -1);
> > > if (ret) {
> > > pr_err("Intel CQM perf registration failed: %d\n", ret);
> > > goto out;
> >
> > So what cleans up mbm_local and mbm_total in that case?
>
> I put all the cleanup code in the cqm_cleanup .. - please see copy below
Ok, missed that.
> @@ -1331,6 +1427,39 @@ static void cqm_cleanup(void)
> kfree(cqm_rmid_ptrs[r]);
>
> kfree(cqm_rmid_ptrs);
> + kfree(mbm_local);
> + kfree(mbm_total);
> + mbm_enabled = false;
> + cqm_enabled = false;
> +}
>
> Thanks,
> Vikas
>
>
> >
> > Thanks,
> >
> > tglx
> >
>
next prev parent reply other threads:[~2016-03-03 18:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 23:48 [PATCH V5 0/6] Intel memory b/w monitoring support Vikas Shivappa
2016-03-01 23:48 ` [PATCH 1/6] x86,perf/cqm: Fix cqm handling of grouping events into a cache_group Vikas Shivappa
2016-03-07 23:04 ` Peter Zijlstra
2016-03-10 0:18 ` Vikas Shivappa
2016-03-01 23:48 ` [PATCH 2/6] x86,perf/cqm: Fix cqm memory leak and notifier leak Vikas Shivappa
2016-03-02 8:00 ` Thomas Gleixner
2016-03-02 17:58 ` Vikas Shivappa
2016-03-02 23:53 ` Vikas Shivappa
2016-03-08 9:22 ` Thomas Gleixner
2016-03-08 19:36 ` Vikas Shivappa
2016-03-01 23:48 ` [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init Vikas Shivappa
2016-03-02 8:04 ` Thomas Gleixner
2016-03-02 17:59 ` Vikas Shivappa
2016-03-02 21:31 ` Vikas Shivappa
2016-03-02 23:56 ` Vikas Shivappa
2016-03-03 7:35 ` Thomas Gleixner
2016-03-03 18:26 ` Vikas Shivappa
2016-03-03 18:37 ` Thomas Gleixner [this message]
2016-03-08 9:25 ` Thomas Gleixner
2016-03-08 19:36 ` Vikas Shivappa
2016-03-01 23:48 ` [PATCH 4/6] x86/mbm: Memory bandwidth monitoring event management Vikas Shivappa
2016-03-07 23:03 ` Peter Zijlstra
2016-03-07 23:27 ` Luck, Tony
2016-03-08 8:49 ` Peter Zijlstra
2016-03-10 22:46 ` Vikas Shivappa
2016-03-10 22:49 ` Vikas Shivappa
2016-03-01 23:48 ` [PATCH 5/6] x86/mbm: RMID Recycling MBM changes Vikas Shivappa
2016-03-01 23:48 ` [PATCH 6/6] x86/mbm: Add support for MBM counter overflow handling Vikas Shivappa
2016-03-02 23:58 ` Vikas Shivappa
2016-03-10 23:32 [PATCH V6 0/6] Intel memory b/w monitoring support Vikas Shivappa
2016-03-10 23:32 ` [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init Vikas Shivappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1603031937210.3597@nanos \
--to=tglx@linutronix.de \
--cc=fenghua.yu@intel.com \
--cc=h.peter.anvin@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=tony.luck@intel.com \
--cc=vikas.shivappa@intel.com \
--cc=vikas.shivappa@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®