mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Du, Changbin" <changbin.du@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	"josh@joshtriplett.org" <josh@joshtriplett.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	"jiangshanlai@gmail.com" <jiangshanlai@gmail.com>,
	John Stultz <john.stultz@linaro.org>, Tejun Heo <tj@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] debugobjects: insulate non-fixup logic related to static obj from fixup callbacks
Date: Sun, 8 May 2016 18:09:47 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1605081808020.3540@nanos> (raw)
In-Reply-To: <0C18FE92A7765D4EB9EE5D38D86A563A05D2DCE6@SHSMSX103.ccr.corp.intel.com>

On Sun, 8 May 2016, Du, Changbin wrote:
> > From: Thomas Gleixner [mailto:tglx@linutronix.de]
> > >  		raw_spin_unlock_irqrestore(&db->lock, flags);
> > >  		/*
> > > -		 * Maybe the object is static.  Let the type specific
> > > +		 * Maybe the object is static. Let the type specific
> > >  		 * code decide what to do.
> > 
> > Instead of doing white space changes you really want to explain the logic
> > here.
> > 
> Comments is in following code.

Well. It's a comment, but the code you replace has better explanations about
statically initialized objects. This should move here.
 
Thanks,

	tglx

  reply	other threads:[~2016-05-08 16:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-06 23:09 changbin.du
2016-05-07  0:16 ` kbuild test robot
2016-05-07  8:26 ` Thomas Gleixner
2016-05-07 12:47   ` Paul E. McKenney
2016-05-08  7:44   ` Du, Changbin
2016-05-08 16:09     ` Thomas Gleixner [this message]
2016-05-09  3:02       ` Du, Changbin
2016-05-09  7:03       ` [PATCH v2] " changbin.du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1605081808020.3540@nanos \
    --to=tglx@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=changbin.du@intel.com \
    --cc=jiangshanlai@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®