mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
	x86@kernel.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: [RFC][WARNING] warning in uncore_pci_probe
Date: Tue, 17 May 2016 21:34:40 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1605172124200.3851@nanos> (raw)
In-Reply-To: <20160517145648.GA28658@krava>

On Tue, 17 May 2016, Jiri Olsa wrote:
> 
> [    2.766466] WARNING: CPU: 0 PID: 1 at arch/x86/events/intel/uncore.c:894 uncore_pci_probe+0x2a8/0x2b0
> 
> I'm booting with nr_cpus=1, which impact physical_to_logical_pkg
> setup.. the map will not be initialized because the rest of cpus
> is never initialized and set in cpu_present_mask
>
> it seems to me we should remove the warning, because it's valid to
> have only single cpu allowed

Single package that is. The package map for cpu 0 is correct, i.e. package 0,
but that code tries to init the PCI/uncore for the other packages.

So, yes. The WARN_ON() is wrong there. We should just return and be done with
it.

Thanks,

	tglx

	

  reply	other threads:[~2016-05-17 19:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17 14:56 Jiri Olsa
2016-05-17 19:34 ` Thomas Gleixner [this message]
2016-05-18  6:16   ` [PATCH] perf/x86/intel/uncore: Remove WARN_ON_ONCE " Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1605172124200.3851@nanos \
    --to=tglx@linutronix.de \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®