mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: kernel test robot <xiaolong.ye@intel.com>
Cc: lkp@01.org, tipbuild@zytor.com,
	LKML <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Vince Weaver <vincent.weaver@maine.edu>,
	Stephane Eranian <eranian@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Kan Liang <kan.liang@intel.com>, Jiri Olsa <jolsa@redhat.com>,
	Borislav Petkov <bp@suse.de>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Adam Borowski <kilobyte@angband.pl>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Anna-Maria Gleixner <anna-maria@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [perf/x86] 8de4a00661: WARNING: CPU: 0 PID: 1 at kernel/locking/mutex-debug.c:80 debug_mutex_unlock+0x20c/0x2b3
Date: Tue, 12 Jul 2016 19:19:19 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1607121916430.4083@nanos> (raw)
In-Reply-To: <alpine.DEB.2.11.1607121839390.4083@nanos>

On Tue, 12 Jul 2016, Thomas Gleixner wrote:
> On Wed, 13 Jul 2016, kernel test robot wrote:
> > [    1.863354] WARNING: CPU: 0 PID: 1 at kernel/locking/mutex-debug.c:80 debug_mutex_unlock+0x20c/0x2b3
> > [    1.877193] DEBUG_LOCKS_WARN_ON(lock->owner != current)
> > 
> > [    1.979431]  [<ffffffff8167508c>] mutex_unlock+0x9/0xb
> > [    1.979431]  [<ffffffff8167508c>] mutex_unlock+0x9/0xb
> > [    1.990691]  [<ffffffff8105a67f>] cpuhp_store_callbacks+0x5a/0x63
> 
> I have a hard time to figure out how that can happen:
> 
> static void cpuhp_store_callbacks(enum cpuhp_state state,
>                                   const char *name,
>                                   int (*startup)(unsigned int cpu),
>                                   int (*teardown)(unsigned int cpu))
> {
>         /* (Un)Install the callbacks for further cpu hotplug operations */
>         struct cpuhp_step *sp;
> 
>         mutex_lock(&cpuhp_state_mutex);
>  	sp = cpuhp_get_step(state);
> 	sp->startup = startup;
>         sp->teardown = teardown;
>         sp->name = name;
>         mutex_unlock(&cpuhp_state_mutex);
> }
> 
> Confused ....

And printing cpuhp_state_mutex.owner does not reduce the confusion level.

[    0.186490] WTF 1           (null)
>         mutex_lock(&cpuhp_state_mutex);
[    0.186848] WTF 2 ffff8800002a4000
>  	sp = cpuhp_get_step(state);
[    0.187174] WTF 3 ffff8800002a4000

and current is:

[    0.205749] CPU: 0 PID: 1 Comm: swapper 
[    0.207410] task: ffff8800002a4000

/me goes digging deeper

 

  reply	other threads:[~2016-07-12 17:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <57851c63.jJgXfR29tgQSoJ3w%xiaolong.ye@intel.com>
2016-07-12 16:41 ` Thomas Gleixner
2016-07-12 17:19   ` Thomas Gleixner [this message]
2016-07-12 19:59     ` Thomas Gleixner
2016-07-13  8:02       ` [tip:core/urgent] cpu/hotplug: Keep enough storage space if SMP=n to avoid array out of bounds scribble tip-bot for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1607121916430.4083@nanos \
    --to=tglx@linutronix.de \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=anna-maria@linutronix.de \
    --cc=bigeasy@linutronix.de \
    --cc=bp@suse.de \
    --cc=eranian@google.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=kilobyte@angband.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tipbuild@zytor.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vincent.weaver@maine.edu \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®