From: Thomas Gleixner <tglx@linutronix.de>
To: Sebastian Frias <sf84@laposte.net>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Marc Zyngier <marc.zyngier@arm.com>,
Jason Cooper <jason@lakedaemon.net>,
LKML <linux-kernel@vger.kernel.org>, Mason <slash.tmp@free.fr>
Subject: Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell()
Date: Thu, 4 Aug 2016 16:03:40 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1608041600090.5547@nanos> (raw)
In-Reply-To: <57A31994.7030503@laposte.net>
On Thu, 4 Aug 2016, Sebastian Frias wrote:
> On 08/04/2016 12:05 PM, Thomas Gleixner wrote:
> (for what is worth, my patch was based on a recent 4.7 that does not has the
> code you mention above)
In future, please always check against mainline or the head of the relevant
maintainer tree.
> > So we better remove the masking in the xlate functions completely and let all
> > the offending device trees trip over the warning so they get eventually fixed.
>
> That's fine by me.
> If you want I can submit a patch that does what you want (if so, should I use
> "fixes" or not?), let me know.
If it is broken then it wants a fixes tag plus an explanation WHY it is
broken, what consequences the breakage has etc.
If it's just a regular code improvement then not.
Decide yourself.
Thanks,
tglx
prev parent reply other threads:[~2016-08-04 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 9:11 Sebastian Frias
2016-08-04 10:05 ` Thomas Gleixner
2016-08-04 10:31 ` Sebastian Frias
2016-08-04 14:03 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1608041600090.5547@nanos \
--to=tglx@linutronix.de \
--cc=grant.likely@secretlab.ca \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=sf84@laposte.net \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®