mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Borislav Petkov <bp@alien8.de>
Subject: RE: [PATCH] x86/AMD: Fix Socket ID for LLC topology for AMD Fam17h systems
Date: Fri, 2 Sep 2016 15:13:31 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1609021508550.5647@nanos> (raw)
In-Reply-To: <DM5PR12MB1387B8B2AA458BF009D973AFF8E50@DM5PR12MB1387.namprd12.prod.outlook.com>

On Fri, 2 Sep 2016, Ghannam, Yazen wrote:
> > > The Socket ID is ApicId[bits] on Fam17h systems.
> > >
> > > Change substraction to logical AND when extracting socket_id
> > > from c->apicid.
> > 
> > So Fam17h will only ever have 2 sockets, right?
> > 
> 
> This is the decoding of the ApicId shown in our latest Programming
> Reference.

I have no idea what your latest reference manual says as it seems to be not
yet public.

> However, I can remove the "& 1" if you think it'll be better.

I's not about what I think is better.

I asked the obvious question whether Fam17h will only ever have two sockets,
because your patch limits it hard to that.

Care to answer that very question instead of handwaving about your
interpretation of a secret manual?

Thanks,

	tglx

  reply	other threads:[~2016-09-02 13:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31 20:21 Yazen Ghannam
2016-09-02  8:41 ` Thomas Gleixner
2016-09-02 12:57   ` Ghannam, Yazen
2016-09-02 13:13     ` Thomas Gleixner [this message]
2016-09-02 16:28       ` Ghannam, Yazen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1609021508550.5647@nanos \
    --to=tglx@linutronix.de \
    --cc=Yazen.Ghannam@amd.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®