mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Rafael Aquini <aquini@redhat.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Andy Lutomirski <luto@kernel.org>,
	Len Brown <len.brown@intel.com>,
	lenb@kernel.org
Subject: Re: [PATCH] Add additional Intel CPU models to crystal_khz whitelist
Date: Sat, 10 Sep 2016 08:35:18 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1609100826500.9305@nanos> (raw)
In-Reply-To: <1473434283-11475-1-git-send-email-prarit@redhat.com>

On Fri, 9 Sep 2016, Prarit Bhargava wrote:

> In commit aa297292d708 ("x86/tsc: Enumerate SKL cpu_khz and tsc_khz via

You cite a commit here, which is nice. If you look at the commit message
then you will notice that _before_ the sentence describing the commit there
is a prefix, which denotes the subsystem to which this patch applies. But
you insist on sending patches w/o a prefix.

Can you please stop this? It's annoying because I have to figure out where
the patch belongs to and have to edit the subject line before applying the
patch.


> @@ -688,11 +688,19 @@ unsigned long native_calibrate_tsc(void)
>  		switch (boot_cpu_data.x86_model) {
>  		case 0x4E:	/* SKL */
>  		case 0x5E:	/* SKL */
> +		case 0x8E:	/* KBL */
> +		case 0x9E:	/* KBL */

asm/intel-family.h provides proper defines for this. And before you add
those, please make a seperate patch which converts the existing hex
constants to the defines.

Thanks,

	tglx

      reply	other threads:[~2016-09-10  6:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09 15:18 Prarit Bhargava
2016-09-10  6:35 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1609100826500.9305@nanos \
    --to=tglx@linutronix.de \
    --cc=aquini@redhat.com \
    --cc=hpa@zytor.com \
    --cc=len.brown@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=prarit@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®