From: Thomas Gleixner <tglx@linutronix.de>
To: Harry Pan <harry.pan@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
gs0622@gmail.com, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, peterz@infradead.org, bp@alien8.de,
srinivas.pandruvada@linux.intel.com
Subject: Re: [PATCH 3/3] perf/x86/rapl: Enable Baytrail/Braswell RAPL support
Date: Tue, 13 Sep 2016 15:41:50 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609131530530.6233@nanos> (raw)
In-Reply-To: <1473571099-1944-3-git-send-email-harry.pan@intel.com>
On Sun, 11 Sep 2016, Harry Pan wrote:
> This patch also enables multiple quirks.
This patch adds a single quirk for Baytrail.
Please stop sending out patches 5 seconds after a review. Take your time
and fixup stuff proper.
> +static void rapl_byt_quirk(void)
> +{
> + int i;
> +
> + /*
> + * Some Atom processors (BYT/BSW) have 2^ESU microjoules
> + * increment, refer to Software Developers' Manual, Vol. 3C,
> + * Order No. 325384, Table 35-8 of MSR_RAPL_POWER_UNIT.
> + *
> + * TODO: In order to fit BYT/BSW quirk model, here remind
> + * this generates timer rate in 80ms; by default
> + * ESU of BYT/BSW is 5, so it leads (1000/200)*2^4.
This sentence is not a sentence and I can't make any sense of it at
all.
What's the TODO here? And why is that TODO not addressed in this patch?
Thanks,
tglx
next prev parent reply other threads:[~2016-09-13 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-11 5:18 [PATCH 1/3] perf/x86/rapl: Enable Apollo Lake " Harry Pan
2016-09-11 5:18 ` [PATCH 2/3] x86/perf/rapl: Make quirk a function pointer Harry Pan
2016-09-11 5:18 ` [PATCH 3/3] perf/x86/rapl: Enable Baytrail/Braswell RAPL support Harry Pan
2016-09-13 13:41 ` Thomas Gleixner [this message]
2016-09-13 17:30 ` Pan, Harry
2016-09-14 16:16 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2016-09-11 3:02 [PATCH 1/3] perf/x86/rapl: Enable Apollo Lake " Harry Pan
2016-09-11 3:02 ` [PATCH 3/3] perf/x86/rapl: Enable Baytrail/Braswell " Harry Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609131530530.6233@nanos \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=gs0622@gmail.com \
--cc=harry.pan@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®