mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Craig Gallek <kraigatgoog@gmail.com>
Cc: David Decotigny <decot@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] genirq: Machine-parsable version of /proc/interrupts
Date: Wed, 14 Sep 2016 15:36:59 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1609141534330.6233@nanos> (raw)
In-Reply-To: <1473783291-122873-1-git-send-email-kraigatgoog@gmail.com>

On Tue, 13 Sep 2016, Craig Gallek wrote:
> +What:		/sys/kernel/irq/<irq>/name
> +Date:		September 2016
> +KernelVersion:	4.9
> +Contact:	Craig Gallek <kraig@google.com>
> +Description:	Human-readable flow handler name as defined by the device
> +		driver.

That's ambigous. device driver reads like a the driver of the device which
uses this irq. I fixed that up.

>  static void free_desc(unsigned int irq)
>  {
>  	struct irq_desc *desc = irq_to_desc(irq);
>  
>  	unregister_irq_proc(irq, desc);
> +	kobject_del(&desc->kobj);

You forgot to move this under the sparse lock protection as well. There is
the same race against a concurrent initcall.

Thanks,

	tglx

  parent reply	other threads:[~2016-09-14 13:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-26 14:25 [PATCH RESEND] " Craig Gallek
2016-08-10 15:26 ` Craig Gallek
2016-09-02 13:52   ` Thomas Gleixner
2016-09-02 14:59 ` Thomas Gleixner
2016-09-06 20:55   ` Craig Gallek
2016-09-09  6:15     ` Thomas Gleixner
2016-09-08 17:34 ` [PATCH v2] " Craig Gallek
2016-09-08 17:57   ` Randy Dunlap
2016-09-08 20:25   ` [PATCH v3] " Craig Gallek
2016-09-08 22:00     ` Randy Dunlap
2016-09-08 22:15       ` Craig Gallek
2016-09-09 12:39         ` Thomas Gleixner
2016-09-09 16:28   ` [PATCH v4] " Craig Gallek
2016-09-09 23:19     ` Thomas Gleixner
2016-09-12 14:12     ` [PATCH v5] " Craig Gallek
2016-09-13 14:50       ` Thomas Gleixner
2016-09-13 16:14       ` [PATCH v6] " Craig Gallek
2016-09-14 13:34         ` [tip:irq/core] genirq: Expose interrupt information through sysfs tip-bot for Craig Gallek
2016-09-14 13:36         ` Thomas Gleixner [this message]
2016-09-14 13:59           ` [PATCH v6] genirq: Machine-parsable version of /proc/interrupts Craig Gallek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1609141534330.6233@nanos \
    --to=tglx@linutronix.de \
    --cc=decot@google.com \
    --cc=kraigatgoog@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®