From: Thomas Gleixner <tglx@linutronix.de>
To: Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com>
Cc: mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de,
dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org,
lukasz.daniluk@intel.com, james.h.cownie@intel.com,
jacob.jun.pan@intel.com
Subject: Re: [PATCH v3 1/4] Add R3MWAIT register and bit to msr-info.h
Date: Thu, 13 Oct 2016 17:28:37 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1610131724200.7777@nanos> (raw)
In-Reply-To: <1476367345-25628-2-git-send-email-grzegorz.andrejczuk@intel.com>
On Thu, 13 Oct 2016, Grzegorz Andrejczuk wrote:
> Subject: [PATCH v3 1/4] Add R3MWAIT register and bit to msr-info.h
Did you ever notice that all patches have a subsystem related prefix before
the sentence decribing the change?
See Documentation/SubmittingPatches. Also git log some/file might give you an idea.
> This commit adds this register prefixed by PHI and bit to msr-info.h
> Reference:
> https://software.intel.com/en-us/blogs/2016/10/06/intel-xeon-phi-product-family-x200-knl-user-mode-ring-3-monitor-and-mwait
> Blog entry is a temporary solution, MSR will be present in the next SDM.
Why do you think that the blog entry link in the changelog does not have
the same issues as the link the code comment?
Just copy the relevant bits into the changelog and be done with it.
Thanks,
tglx
next prev parent reply other threads:[~2016-10-13 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 14:02 [PATCH v3 0/4] Enabling Ring 3 MONITOR/MWAIT feature for Knights Landing Grzegorz Andrejczuk
2016-10-13 14:02 ` [PATCH v3 1/4] Add R3MWAIT register and bit to msr-info.h Grzegorz Andrejczuk
2016-10-13 15:28 ` Thomas Gleixner [this message]
2016-10-13 14:02 ` [PATCH v3 2/4] Add enabling of the R3 MWAIT during boot for KNL Grzegorz Andrejczuk
2016-10-13 15:32 ` Thomas Gleixner
2016-10-13 14:02 ` [PATCH v3 3/4] Add hwcap2 for x86 Grzegorz Andrejczuk
2016-10-13 15:36 ` Thomas Gleixner
2016-10-13 14:02 ` [PATCH v3 4/4] Add R3MWAIT to CPU features Grzegorz Andrejczuk
2016-10-13 15:39 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610131724200.7777@nanos \
--to=tglx@linutronix.de \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=grzegorz.andrejczuk@intel.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@intel.com \
--cc=james.h.cownie@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.daniluk@intel.com \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®