mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com>
Cc: mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de,
	dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org,
	lukasz.daniluk@intel.com, james.h.cownie@intel.com,
	jacob.jun.pan@intel.com
Subject: Re: [PATCH v3 4/4] Add R3MWAIT to CPU features
Date: Thu, 13 Oct 2016 17:39:34 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1610131736441.7777@nanos> (raw)
In-Reply-To: <1476367345-25628-5-git-send-email-grzegorz.andrejczuk@intel.com>

On Thu, 13 Oct 2016, Grzegorz Andrejczuk wrote:
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -1108,6 +1108,9 @@ static void identify_cpu(struct cpuinfo_x86 *c)
>  #endif
>  	/* The boot/hotplug time assigment got cleared, restore it */
>  	c->logical_proc_id = topology_phys_to_logical_pkg(c->phys_proc_id);
> +
> +	if (cpu_has(c, X86_FEATURE_PHIR3MWAIT))
> +		elf_hwcap2 |= HWCAP2_PHIR3MWAIT;

Why can't you just set that bit in probe_xeon_phi_r3mwait()?

Just because its so much fun to sprinkle code at random places, right?

Sigh.

	tglx

      reply	other threads:[~2016-10-13 15:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13 14:02 [PATCH v3 0/4] Enabling Ring 3 MONITOR/MWAIT feature for Knights Landing Grzegorz Andrejczuk
2016-10-13 14:02 ` [PATCH v3 1/4] Add R3MWAIT register and bit to msr-info.h Grzegorz Andrejczuk
2016-10-13 15:28   ` Thomas Gleixner
2016-10-13 14:02 ` [PATCH v3 2/4] Add enabling of the R3 MWAIT during boot for KNL Grzegorz Andrejczuk
2016-10-13 15:32   ` Thomas Gleixner
2016-10-13 14:02 ` [PATCH v3 3/4] Add hwcap2 for x86 Grzegorz Andrejczuk
2016-10-13 15:36   ` Thomas Gleixner
2016-10-13 14:02 ` [PATCH v3 4/4] Add R3MWAIT to CPU features Grzegorz Andrejczuk
2016-10-13 15:39   ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1610131736441.7777@nanos \
    --to=tglx@linutronix.de \
    --cc=bp@suse.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=grzegorz.andrejczuk@intel.com \
    --cc=hpa@zytor.com \
    --cc=jacob.jun.pan@intel.com \
    --cc=james.h.cownie@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukasz.daniluk@intel.com \
    --cc=mingo@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®