From: Vince Weaver <vincent.weaver@maine.edu>
To: Wang Nan <wangnan0@huawei.com>
Cc: mtk.manpages@gmail.com, pi3orama@163.com,
linux-kernel@vger.kernel.org, linux-man@vger.kernel.org,
lizefan@huawei.com, vincent.weaver@maine.edu
Subject: Re: [PATCH 1/2] perf_event_open.2: Document PERF_EVENT_IOC_PAUSE_OUTPUT
Date: Fri, 21 Oct 2016 17:16:22 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.20.1610211710440.16183@macbook-air> (raw)
In-Reply-To: <1477049893-143199-1-git-send-email-wangnan0@huawei.com>
On Fri, 21 Oct 2016, Wang Nan wrote:
> -.SS Using prctl(2)
> +.SS Using prctl
why this change?
> +.BR PERF_EVENT_IOC_PAUSE_OUTPUT " (since Linux 4.7)"
> +.\" commit 86e7972f690c1017fd086cdfe53d8524e68c661c
> +This allows pausing and resuming the event's ring-buffer. A
> +paused ring-buffer does not prevent samples generation, but simply
> +discards them. The discarded samples are considered lost, causes
> +.BR PERF_RECORD_LOST
> +to be generated when possible.
I don't know if it's worth mentioning that the reason to add this is to
allow reading the ring-buffer without having to worry about data being
overwritten.
There are a few odd wording choices (mostly plural nouns) but otherwise
looks fine to me.
Reviewed-by: Vince Weaver <vincent.weaver@maine.edu>
next prev parent reply other threads:[~2016-10-21 21:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 11:38 Wang Nan
2016-10-21 11:38 ` [PATCH 2/2] perf_event_open.2: Document write_backward Wang Nan
2016-10-21 21:25 ` Vince Weaver
2016-10-22 10:05 ` Michael Kerrisk (man-pages)
2016-10-24 6:44 ` Wangnan (F)
2016-10-21 21:16 ` Vince Weaver [this message]
2016-10-22 10:00 ` [PATCH 1/2] perf_event_open.2: Document PERF_EVENT_IOC_PAUSE_OUTPUT Michael Kerrisk (man-pages)
2016-10-22 10:02 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610211710440.16183@macbook-air \
--to=vincent.weaver@maine.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mtk.manpages@gmail.com \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®