From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [GIT pull] timer updates for 4.9
Date: Mon, 24 Oct 2016 23:36:10 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1610242324250.4815@nanos> (raw)
In-Reply-To: <CA+55aFxLdf3brn_wJK7cPiDCLoSg2g-C3Sm0B6zZbcYkCO0hFw@mail.gmail.com>
On Mon, 24 Oct 2016, Linus Torvalds wrote:
> The one I'm *currently* testing seems to work for me, but that's
> because I moved the timer into klogd and that just avoids the issue.
>
> But I'll attach my old patch just for your testing pleasure.
Of course it does not trigger... I probably need to test it on a desktop
machine to get all the goodies of that gnome shell ignoring signals.
> The fact that it actually mostly worked - and then had some very odd
> behavior much later on - makes me wonder if we might have other users
> that could have timers that get started early, and nobody notices
> because most of the time it doesn't cause any real issues.
I added a bunch of timers before init_timers(). There is no fallout aside
of the timers being queued into a random bucket and the spinlock bad magic
bug, which actually happens at spin_lock and not at unlock as I assumed.
While queueing timers before init_timers() is not correct, I think that the
early queueing is a red herring. We should really try to isolate the root
cause of this wreckage.
Can you retest that old patch with my combo patch applied and see if it
still triggers? If yes, which I expect, debugobjects might give us the hint
what to look for.
Thanks,
tglx
prev parent reply other threads:[~2016-10-24 21:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 12:02 Thomas Gleixner
2016-10-23 22:39 ` Linus Torvalds
2016-10-23 23:20 ` Linus Torvalds
2016-10-24 9:39 ` Thomas Gleixner
2016-10-24 14:51 ` Thomas Gleixner
2016-10-24 15:13 ` Thomas Gleixner
2016-10-25 14:57 ` [tip:timers/urgent] timers: Plug locking race vs. timer migration tip-bot for Thomas Gleixner
2016-10-25 14:58 ` [tip:timers/urgent] timers: Lock base for same bucket optimization tip-bot for Thomas Gleixner
2016-10-24 17:16 ` [GIT pull] timer updates for 4.9 Linus Torvalds
2016-10-24 19:09 ` Thomas Gleixner
2016-10-24 19:30 ` Linus Torvalds
2016-10-24 21:36 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610242324250.4815@nanos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®