* [PATCH] driver-core: fix odd_ptr_err.cocci warnings
@ 2016-11-10 20:16 Julia Lawall
[not found] ` <CAE_wzQ_st6sBugdFRGX8VgSXcRqNCo3QcPwr5B8XpR-cQft6Eg@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2016-11-10 20:16 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: kbuild-all, devel, Greg Kroah-Hartman, Olof Johansson,
Guenter Roeck, Thierry Escande, linux-kernel
PTR_ERR should access the value just tested by IS_ERR
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
0-day warning related to the following commit:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing
head: dfea747d2aba77443acf7ce6fa37caa729bd034c
commit: 79543cf2b18ea4a35f8864849d7ad8882ea8a23d [10/14] driver-core: add test module for asynchronous probing
I haven't checked the context in detail.
test_async_driver_probe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/base/test/test_async_driver_probe.c
+++ b/drivers/base/test/test_async_driver_probe.c
@@ -119,7 +119,7 @@ static int __init test_async_probe_init(
sync_dev_1 = platform_device_register_simple("test_sync_driver", 1,
NULL, 0);
if (IS_ERR(async_dev_1)) {
- error = PTR_ERR(sync_dev_1);
+ error = PTR_ERR(async_dev_1);
pr_err("failed to create sync_dev_1: %d", error);
goto err_unregister_sync_driver;
}
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <CAE_wzQ_st6sBugdFRGX8VgSXcRqNCo3QcPwr5B8XpR-cQft6Eg@mail.gmail.com>]
* Re: [PATCH] driver-core: fix odd_ptr_err.cocci warnings [not found] ` <CAE_wzQ_st6sBugdFRGX8VgSXcRqNCo3QcPwr5B8XpR-cQft6Eg@mail.gmail.com> @ 2016-11-10 20:19 ` Dmitry Torokhov 2016-11-10 20:22 ` Julia Lawall 0 siblings, 1 reply; 3+ messages in thread From: Dmitry Torokhov @ 2016-11-10 20:19 UTC (permalink / raw) To: Dmitry Torokhov Cc: Julia Lawall, kbuild-all, devel, Greg Kroah-Hartman, Olof Johansson, Guenter Roeck, Thierry Escande, linux-kernel [ resending as plain text ] On Thu, Nov 10, 2016 at 12:18 PM, Dmitry Torokhov <dtor@chromium.org> wrote: > > > On Thu, Nov 10, 2016 at 12:16 PM, Julia Lawall <julia.lawall@lip6.fr> wrote: >> >> PTR_ERR should access the value just tested by IS_ERR >> >> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci >> >> CC: Dmitry Torokhov <dtor@chromium.org> >> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> >> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> >> --- >> >> 0-day warning related to the following commit: >> >> tree: >> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git >> driver-core-testing >> head: dfea747d2aba77443acf7ce6fa37caa729bd034c >> commit: 79543cf2b18ea4a35f8864849d7ad8882ea8a23d [10/14] driver-core: add >> test module for asynchronous probing >> >> I haven't checked the context in detail. >> >> >> test_async_driver_probe.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- a/drivers/base/test/test_async_driver_probe.c >> +++ b/drivers/base/test/test_async_driver_probe.c >> @@ -119,7 +119,7 @@ static int __init test_async_probe_init( >> sync_dev_1 = platform_device_register_simple("test_sync_driver", >> 1, >> NULL, 0); >> if (IS_ERR(async_dev_1)) { >> - error = PTR_ERR(sync_dev_1); >> + error = PTR_ERR(async_dev_1); > > > NAK. It should be "if (IS_ERR(sync_dev_1)) {" > >> >> pr_err("failed to create sync_dev_1: %d", error); >> goto err_unregister_sync_driver; >> } > > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] driver-core: fix odd_ptr_err.cocci warnings 2016-11-10 20:19 ` Dmitry Torokhov @ 2016-11-10 20:22 ` Julia Lawall 0 siblings, 0 replies; 3+ messages in thread From: Julia Lawall @ 2016-11-10 20:22 UTC (permalink / raw) To: Dmitry Torokhov Cc: kbuild-all, devel, Greg Kroah-Hartman, Olof Johansson, Guenter Roeck, Thierry Escande, linux-kernel On Thu, 10 Nov 2016, Dmitry Torokhov wrote: > [ resending as plain text ] > > On Thu, Nov 10, 2016 at 12:18 PM, Dmitry Torokhov <dtor@chromium.org> wrote: > > > > > > On Thu, Nov 10, 2016 at 12:16 PM, Julia Lawall <julia.lawall@lip6.fr> wrote: > >> > >> PTR_ERR should access the value just tested by IS_ERR > >> > >> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > >> > >> CC: Dmitry Torokhov <dtor@chromium.org> > >> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> > >> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > >> --- > >> > >> 0-day warning related to the following commit: > >> > >> tree: > >> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git > >> driver-core-testing > >> head: dfea747d2aba77443acf7ce6fa37caa729bd034c > >> commit: 79543cf2b18ea4a35f8864849d7ad8882ea8a23d [10/14] driver-core: add > >> test module for asynchronous probing > >> > >> I haven't checked the context in detail. > >> > >> > >> test_async_driver_probe.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> --- a/drivers/base/test/test_async_driver_probe.c > >> +++ b/drivers/base/test/test_async_driver_probe.c > >> @@ -119,7 +119,7 @@ static int __init test_async_probe_init( > >> sync_dev_1 = platform_device_register_simple("test_sync_driver", > >> 1, > >> NULL, 0); > >> if (IS_ERR(async_dev_1)) { > >> - error = PTR_ERR(sync_dev_1); > >> + error = PTR_ERR(async_dev_1); > > > > > > NAK. It should be "if (IS_ERR(sync_dev_1)) {" Indeed, I should have noticed that. Will you make the fix, or should I revise the proposed patch? julia > > > >> > >> pr_err("failed to create sync_dev_1: %d", error); > >> goto err_unregister_sync_driver; > >> } > > > > > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-10 20:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-10 20:16 [PATCH] driver-core: fix odd_ptr_err.cocci warnings Julia Lawall
[not found] ` <CAE_wzQ_st6sBugdFRGX8VgSXcRqNCo3QcPwr5B8XpR-cQft6Eg@mail.gmail.com>
2016-11-10 20:19 ` Dmitry Torokhov
2016-11-10 20:22 ` Julia Lawall
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®