From: Thomas Gleixner <tglx@linutronix.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: Len Brown <lenb@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Len Brown <len.brown@intel.com>
Subject: Re: [PATCH 2/5] x86: remove idle_notifier
Date: Wed, 7 Dec 2016 12:46:12 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1612071243410.3448@nanos> (raw)
In-Reply-To: <20161206165420.GA4406@amd>
On Tue, 6 Dec 2016, Pavel Machek wrote:
> > From: Len Brown <len.brown@intel.com>
> >
> > Upon removal of the i7300_idle driver, the idle_notifer is unused.
>
> Actually... do we want to keep this this one? There's "cpu is loaded"
> led trigger, which is implemented on arm but not on x86.
>
> I tried to patch process.c, but this would be easier (and does not
> require new hooks).
>
> Does that make sense?
No. Notifiers are crap.
I assume this LED thing is just for entertainment purposes as I cannot
figure out why it would be useful. ARM has it does not qualify as useful.
Thanks,
tglx
next prev parent reply other threads:[~2016-12-07 11:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 6:23 [PATCH 0/5] x86: remove idle notifier Len Brown
2016-11-18 6:23 ` [PATCH 1/5] i7300_idle: remove this driver Len Brown
2016-11-18 6:23 ` [PATCH 2/5] x86: remove idle_notifier Len Brown
2016-11-18 11:19 ` [tip:x86/idle] x86/idle: Remove idle_notifier tip-bot for Len Brown
2016-12-06 16:54 ` [PATCH 2/5] x86: remove idle_notifier Pavel Machek
2016-12-07 11:46 ` Thomas Gleixner [this message]
2016-12-07 13:40 ` Pavel Machek
2016-12-08 9:18 ` Thomas Gleixner
2016-12-08 22:05 ` Pavel Machek
2016-12-08 22:53 ` Thomas Gleixner
2016-11-18 6:23 ` [PATCH 3/5] x86: remove is_idle flag Len Brown
2016-11-18 11:20 ` [tip:x86/idle] x86/idle: Remove " tip-bot for Len Brown
2016-11-18 6:23 ` [PATCH 4/5] x86: remove x86_test_and_clear_bit_percpu() Len Brown
2016-11-18 11:20 ` [tip:x86/idle] x86: Remove x86_test_and_clear_bit_percpu() tip-bot for Len Brown
2016-11-18 6:23 ` [PATCH 5/5] x86: remove enter_idle(), exit_idle() Len Brown
2016-11-18 11:21 ` [tip:x86/idle] x86/idle: Remove " tip-bot for Len Brown
2016-11-18 11:19 ` [tip:x86/idle] i7300_idle: Remove this driver tip-bot for Len Brown
2016-11-18 8:17 ` [PATCH 0/5] x86: remove idle notifier Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1612071243410.3448@nanos \
--to=tglx@linutronix.de \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome