From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Borislav Petkov <bp@alien8.de>,
Erik Veijola <erik.veijola@intel.com>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH] x86/mce: Make timer handling more robust
Date: Tue, 31 Jan 2017 14:33:29 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1701311432080.3457@nanos> (raw)
In-Reply-To: <alpine.DEB.2.20.1701310936080.3457@nanos>
On Tue, 31 Jan 2017, Thomas Gleixner wrote:
> +static void mce_start_timer(struct timer_list *t)
> {
> unsigned long iv = check_interval * HZ;
>
> if (mca_cfg.ignore_ce || !iv)
> return;
>
> - per_cpu(mce_next_interval, cpu) = iv;
> -
> - t->expires = round_jiffies(jiffies + iv);
> - add_timer_on(t, cpu);
> + this_cpu_write(mce_next_interval, iv);
> + __start_timer(t, jiffies + iv);
Bah. That's wrong. Delta patch below:
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1782,7 +1782,7 @@ static void mce_start_timer(struct timer
return;
this_cpu_write(mce_next_interval, iv);
- __start_timer(t, jiffies + iv);
+ __start_timer(t, iv);
}
static void __mcheck_cpu_setup_timer(void)
next prev parent reply other threads:[~2017-01-31 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 8:37 Thomas Gleixner
2017-01-31 13:33 ` Thomas Gleixner [this message]
2017-01-31 18:37 ` Borislav Petkov
2017-02-01 9:29 ` Veijola, Erik
2017-01-31 18:36 ` Borislav Petkov
2017-01-31 20:51 ` [tip:x86/urgent] " tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1701311432080.3457@nanos \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=erik.veijola@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®