mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, mingo@redhat.com,
	hpa@zytor.com
Subject: Re: [PATCH] x86: Clean up a tiny description mistake in kernel ld script
Date: Fri, 10 Feb 2017 12:46:39 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1702101244290.4036@nanos> (raw)
In-Reply-To: <1486041922-5515-1-git-send-email-bhe@redhat.com>

On Thu, 2 Feb 2017, Baoquan He wrote:

> Remove the redundent word "is".
> 
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
>  arch/x86/kernel/vmlinux.lds.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> index e79f15f..f8f56b9 100644
> --- a/arch/x86/kernel/vmlinux.lds.S
> +++ b/arch/x86/kernel/vmlinux.lds.S
> @@ -8,8 +8,8 @@
>   *
>   *
>   * Don't define absolute symbols until and unless you know that symbol
> - * value is should remain constant even if kernel image is relocated
> - * at run time. Absolute symbols are not relocated. If symbol value should
> + * value should remain constant even if kernel image is relocated at

And while at it we could make it a proper sentence:

  ... you know that the symbol value should .... even if the kernel ....

> + * run time. Absolute symbols are not relocated. If symbol value should

If the symbol value ... 

>   * change if kernel is relocated, make the symbol section relative and

if the kernel 

>   * put it inside the section definition.
>   */
> -- 
> 2.5.5
> 
> 

  reply	other threads:[~2017-02-10 11:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-02 13:25 Baoquan He
2017-02-10 11:46 ` Thomas Gleixner [this message]
2017-02-10 12:37   ` Baoquan He
2017-02-10 12:51   ` [PATCH v2] " Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1702101244290.4036@nanos \
    --to=tglx@linutronix.de \
    --cc=bhe@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®