From: Thomas Gleixner <tglx@linutronix.de>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: "Jérémy Lefaure" <jeremy.lefaure@lse.epita.fr>,
x86@kernel.org, "Borislav Petkov" <bp@suse.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/vm86: fix unused variable warning if THP is disabled.
Date: Mon, 13 Feb 2017 16:49:18 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1702131646420.3619@nanos> (raw)
In-Reply-To: <20170213125228.63645-1-kirill.shutemov@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 532 bytes --]
On Mon, 13 Feb 2017, Kirill A. Shutemov wrote:
> GCC complaines on unused variable 'vma' in mark_screen_rdonly() if THP
> is disalbed:
>
> arch/x86/kernel/vm86_32.c: In function ‘mark_screen_rdonly’:
> arch/x86/kernel/vm86_32.c:180:26: warning: unused variable ‘vma’
> [-Wunused-variable]
> struct vm_area_struct *vma = find_vma(mm, 0xA0000);
> ^~~
> It shoudln't really. The whole block has to be eliminated as
> pmd_trans_huge() is 0 if THP is disabled.
Indeed. That's outright silly.
next prev parent reply other threads:[~2017-02-13 15:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 4:38 [PATCH] x86/vm86: fix compilation warning on a unused variable Jérémy Lefaure
2016-12-08 8:33 ` Borislav Petkov
2016-12-08 17:51 ` Jérémy Lefaure
2016-12-08 10:50 ` Kirill A. Shutemov
2016-12-08 11:44 ` Kirill A. Shutemov
2016-12-08 18:25 ` Jérémy Lefaure
2016-12-12 14:52 ` Kirill A. Shutemov
2016-12-17 4:19 ` Jérémy Lefaure
2017-02-12 14:01 ` Borislav Petkov
2017-02-13 4:20 ` Jérémy Lefaure
2017-02-13 10:03 ` Borislav Petkov
2017-02-13 12:52 ` [PATCH] x86/vm86: fix unused variable warning if THP is disabled Kirill A. Shutemov
2017-02-13 15:49 ` Thomas Gleixner [this message]
2017-02-13 17:47 ` Borislav Petkov
2017-02-13 18:07 ` [tip:x86/urgent] x86/vm86: Fix " tip-bot for Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1702131646420.3619@nanos \
--to=tglx@linutronix.de \
--cc=bp@suse.de \
--cc=jeremy.lefaure@lse.epita.fr \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®