From: Thomas Gleixner <tglx@linutronix.de>
To: Andrew Banman <abanman@hpe.com>
Cc: mingo@redhat.com, akpm@linux-foundation.org, hpa@zytor.com,
mike.travis@hpe.com, rja@hpe.com, sivanich@hpe.com,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] x86/platform/uv/BAU: Add status_mmr_loc to locate message status bits
Date: Thu, 16 Feb 2017 19:07:10 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1702161903440.3543@nanos> (raw)
In-Reply-To: <1487123931-56809-3-git-send-email-abanman@hpe.com>
On Tue, 14 Feb 2017, Andrew Banman wrote:
> The location of the ERROR and BUSY status bits depends on the descriptor
> index, i.e. the CPU, of the message. We determine this location ahead of
> the wait_completion loop to avoid repeating the calculation.
>
> Split out the status location calculation into a new routine,
> status_mmr_loc, to be used within each uv*_wait_completion routine.
And the reason for this is? You just tell WHAT you are doing, not the WHY.
Looking at the patch which implements the uv4 wait function it uses the
thing as well. So for the casual reader there is no point.
The only reason i figured why you want to do that is to reduce the number
of arguments to the wait function, correct?
If yes, then spell it out. If no, please enlighten me.
Thanks,
tglx
next prev parent reply other threads:[~2017-02-16 18:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 1:58 [PATCH 0/6] x86/platform/uv/BAU: UV4 message completion and initialization updates Andrew Banman
2017-02-15 1:58 ` [PATCH 1/6] x86/platform/uv/BAU: Declare bau_operations struct after other BAU structs Andrew Banman
2017-02-16 18:00 ` Thomas Gleixner
2017-02-15 1:58 ` [PATCH 2/6] x86/platform/uv/BAU: Add status_mmr_loc to locate message status bits Andrew Banman
2017-02-16 18:07 ` Thomas Gleixner [this message]
2017-02-16 21:53 ` Andrew Banman
2017-02-15 1:58 ` [PATCH 3/6] x86/platform/uv/BAU: Add wait_completion to bau_operations Andrew Banman
2017-02-16 18:11 ` Thomas Gleixner
2017-02-15 1:58 ` [PATCH 4/6] x86/platform/uv/BAU: Implement uv4_wait_completion with read_status Andrew Banman
2017-02-16 18:25 ` Thomas Gleixner
2017-02-15 1:58 ` [PATCH 5/6] x86/platform/uv/BAU: Remove initial write to swack register Andrew Banman
2017-02-16 18:28 ` Thomas Gleixner
2017-02-15 1:58 ` [PATCH 6/6] x86/platform/uv/BAU: Add payload descriptor qualifier Andrew Banman
2017-02-16 18:42 ` Thomas Gleixner
2017-02-16 21:12 ` Andrew Banman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1702161903440.3543@nanos \
--to=tglx@linutronix.de \
--cc=abanman@hpe.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.travis@hpe.com \
--cc=mingo@redhat.com \
--cc=rja@hpe.com \
--cc=sivanich@hpe.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®