From: Thomas Gleixner <tglx@linutronix.de>
To: Arun Raghavan <arun@arunraghavan.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RESEND 2] [PATCH] rlimits: Print more information when limits are exceeded
Date: Wed, 1 Mar 2017 11:00:43 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1703011055130.4005@nanos> (raw)
In-Reply-To: <20170218083750.12305-1-arun@arunraghavan.net>
On Sat, 18 Feb 2017, Arun Raghavan wrote:
> This dumps some information in logs when a process exceeds its CPU or RT
> limits (soft and hard). Makes debugging easier when userspace triggers
> these limits.
Sigh. This changelog sucks. "dumps some information" is pretty useless and
it does not explain WHY you want to do that. Please structure the changelog
in a way which makes it easy to understand.
1) Problem description
2) Solution
> diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c
> index e9e8c10..6dbcf84 100644
> --- a/kernel/time/posix-cpu-timers.c
> +++ b/kernel/time/posix-cpu-timers.c
> @@ -860,6 +860,9 @@ static void check_thread_timers(struct task_struct *tsk,
> * At the hard limit, we just die.
> * No need to calculate anything else now.
> */
> + printk(KERN_INFO
pr_info("CPU Watchdog Timeout (hard): %s[%d]\n",
and no artificial line breaks, please.
Thanks,
tglx
next prev parent reply other threads:[~2017-03-01 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 8:37 Arun Raghavan
2017-02-18 15:47 ` Arun Raghavan
2017-03-01 10:00 ` Thomas Gleixner [this message]
2017-03-01 14:53 ` [PATCH v2] rlimits: Print more information when CPU/RT " Arun Raghavan
2017-03-13 20:36 ` [tip:timers/core] " tip-bot for Arun Raghavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1703011055130.4005@nanos \
--to=tglx@linutronix.de \
--cc=arun@arunraghavan.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®