From: Julia Lawall <julia.lawall@lip6.fr>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com,
outreachy-kernel@googlegroups.com, kirk@reisers.ca,
samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org,
speakup@linux-speakup.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH 5/6] staging: speakup: Alignment should match open parenthesis
Date: Thu, 9 Mar 2017 22:36:24 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1703092232520.2306@hadrien> (raw)
In-Reply-To: <20170309190320.25681-6-arushisinghal19971997@gmail.com>
On Fri, 10 Mar 2017, Arushi Singhal wrote:
> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> if (synth_request_region(speakup_info.port_tts - 1,
> - SYNTH_IO_EXTENT)) {
> + SYNTH_IO_EXTENT)) {
> pr_warn("sorry, port already reserved\n");
> return -EBUSY;
> }
> @@ -270,7 +270,7 @@ static int synth_probe(struct spk_synth *synth)
> } else {
> for (i = 0; synth_portlist[i]; i++) {
> if (synth_request_region(synth_portlist[i],
> - SYNTH_IO_EXTENT)) {
> + SYNTH_IO_EXTENT)) {
These are not correct. SYNTH_IO_EXTENT should be lines up with the right
side of the ( of the argument list of which it is an element. So the
original code is either correct or close to correct.
julia
next prev parent reply other threads:[~2017-03-09 21:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 19:03 [PATCH 0/6] staging: speakup: multiple checkpatch issues Arushi Singhal
2017-03-09 19:03 ` [PATCH 1/6] staging: speakup: fix "Alignment match open parenthesis" Arushi Singhal
2017-03-09 19:03 ` [PATCH 2/6] staging: speakup: Placed Logical on the previous line Arushi Singhal
2017-03-09 19:03 ` [PATCH 3/6] staging: speakup: spaces preferred around operator Arushi Singhal
2017-03-09 19:03 ` [PATCH 4/6] staging: speakup: identation should use tabs Arushi Singhal
2017-03-09 19:03 ` [PATCH 5/6] staging: speakup: Alignment should match open parenthesis Arushi Singhal
2017-03-09 21:36 ` Julia Lawall [this message]
2017-03-09 19:03 ` [PATCH 6/6] staging: speakup: Add blank line after function/struct/union/enum declarations Arushi Singhal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1703092232520.2306@hadrien \
--to=julia.lawall@lip6.fr \
--cc=arushisinghal19971997@gmail.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®