From: Thomas Gleixner <tglx@linutronix.de>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: linux-kernel@vger.kernel.org, john.stultz@linaro.org,
arnd@arndb.de, y2038@lists.linaro.org
Subject: Re: [RESEND PATCH 3/7] Change k_clock clock_get() to use timespec64
Date: Sun, 19 Mar 2017 12:03:54 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1703191159550.3781@nanos> (raw)
In-Reply-To: <1489900666-32268-4-git-send-email-deepa.kernel@gmail.com>
On Sat, 18 Mar 2017, Deepa Dinamani wrote:
> - int (*clock_get) (const clockid_t which_clock, struct timespec * tp);
> + int (*clock_get) (const clockid_t which_clock, struct timespec64 * tp);
If you change things, then please fixup the white space noise as well '*tp'
is the proper syntax.
> @@ -1033,12 +1033,14 @@ SYSCALL_DEFINE2(clock_gettime, const clockid_t, which_clock,
> {
> struct k_clock *kc = clockid_to_kclock(which_clock);
> struct timespec kernel_tp;
> + struct timespec64 kernel_tp64;
Ordering please
Other than the nitpicks, this looks good.
next prev parent reply other threads:[~2017-03-19 11:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-19 5:17 [RESEND PATCH 0/7] Change k_clock interfaces " Deepa Dinamani
2017-03-19 5:17 ` [RESEND PATCH 1/7] time: Delete do_sys_setimeofday() Deepa Dinamani
2017-03-19 10:57 ` Thomas Gleixner
2017-03-21 17:21 ` kbuild test robot
2017-03-21 18:57 ` Deepa Dinamani
2017-03-19 5:17 ` [RESEND PATCH 2/7] time: Change posix clocks ops interfaces to use timespec64 Deepa Dinamani
2017-03-19 10:51 ` Thomas Gleixner
2017-03-20 20:39 ` Deepa Dinamani
2017-03-20 20:40 ` Thomas Gleixner
2017-03-21 8:19 ` Arnd Bergmann
2017-03-21 9:04 ` Thomas Gleixner
2017-03-20 21:40 ` [Y2038] " Tomoyoshi ASANO
2017-03-19 18:06 ` Richard Cochran
2017-03-20 20:38 ` Deepa Dinamani
2017-03-19 5:17 ` [RESEND PATCH 3/7] Change k_clock clock_get() " Deepa Dinamani
2017-03-19 11:03 ` Thomas Gleixner [this message]
2017-03-19 5:17 ` [RESEND PATCH 4/7] Change k_clock clock_getres() " Deepa Dinamani
2017-03-19 5:17 ` [RESEND PATCH 5/7] Change k_clock clock_set() " Deepa Dinamani
2017-03-19 5:17 ` [RESEND PATCH 6/7] Change k_clock timer_set() and timer_get() " Deepa Dinamani
2017-03-19 5:17 ` [RESEND PATCH 7/7] Change k_clock nsleep() " Deepa Dinamani
2017-03-19 11:06 ` [RESEND PATCH 0/7] Change k_clock interfaces " Thomas Gleixner
2017-03-20 20:39 ` Deepa Dinamani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1703191159550.3781@nanos \
--to=tglx@linutronix.de \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®